Re: [PATCH] rtlwifi: remove duplicate code

2018-05-24 Thread Gustavo A. R. Silva
Hi Joe, On 05/24/2018 02:24 PM, Joe Perches wrote: On Thu, 2018-05-24 at 13:54 -0500, Gustavo A. R. Silva wrote: Remove and refactor some code in order to avoid having identical code for different branches. True and nice tool and patch submittal thanks. Notice that the logic has been there

Re: [PATCH] rtlwifi: remove duplicate code

2018-05-24 Thread Joe Perches
On Thu, 2018-05-24 at 13:54 -0500, Gustavo A. R. Silva wrote: > Remove and refactor some code in order to avoid having identical code > for different branches. True and nice tool and patch submittal thanks. > Notice that the logic has been there since 2014. But perhaps the original logic is a

[PATCH] rtlwifi: remove duplicate code

2018-05-24 Thread Gustavo A. R. Silva
Remove and refactor some code in order to avoid having identical code for different branches. Notice that the logic has been there since 2014. Addresses-Coverity-ID: 1426199 ("Identical code for different branches") Signed-off-by: Gustavo A. R. Silva ---