Re: [PATCH] sctp: fix ASCONF list handling

2015-06-02 Thread Neil Horman
On Mon, Jun 01, 2015 at 07:28:21PM -0300, Marcelo Ricardo Leitner wrote: > On Mon, Jun 01, 2015 at 10:00:28AM -0400, Neil Horman wrote: > > On Fri, May 29, 2015 at 01:50:37PM -0300, Marcelo Ricardo Leitner wrote: > > > On Fri, May 29, 2015 at 09:17:26AM -0400, Neil Horman wrote: > > > > On Thu, May

Re: [PATCH] sctp: fix ASCONF list handling

2015-06-01 Thread Marcelo Ricardo Leitner
On Mon, Jun 01, 2015 at 10:00:28AM -0400, Neil Horman wrote: > On Fri, May 29, 2015 at 01:50:37PM -0300, Marcelo Ricardo Leitner wrote: > > On Fri, May 29, 2015 at 09:17:26AM -0400, Neil Horman wrote: > > > On Thu, May 28, 2015 at 11:46:29AM -0300, Marcelo Ricardo Leitner wrote: > > > > On Thu, May

Re: [PATCH] sctp: fix ASCONF list handling

2015-06-01 Thread Neil Horman
On Fri, May 29, 2015 at 01:50:37PM -0300, Marcelo Ricardo Leitner wrote: > On Fri, May 29, 2015 at 09:17:26AM -0400, Neil Horman wrote: > > On Thu, May 28, 2015 at 11:46:29AM -0300, Marcelo Ricardo Leitner wrote: > > > On Thu, May 28, 2015 at 10:27:32AM -0300, Marcelo Ricardo Leitner wrote: > > > >

Re: [PATCH] sctp: fix ASCONF list handling

2015-05-29 Thread Marcelo Ricardo Leitner
On Fri, May 29, 2015 at 09:17:26AM -0400, Neil Horman wrote: > On Thu, May 28, 2015 at 11:46:29AM -0300, Marcelo Ricardo Leitner wrote: > > On Thu, May 28, 2015 at 10:27:32AM -0300, Marcelo Ricardo Leitner wrote: > > > On Thu, May 28, 2015 at 08:17:27AM -0300, Marcelo Ricardo Leitner wrote: > > > >

Re: [PATCH] sctp: fix ASCONF list handling

2015-05-29 Thread Neil Horman
On Thu, May 28, 2015 at 11:46:29AM -0300, Marcelo Ricardo Leitner wrote: > On Thu, May 28, 2015 at 10:27:32AM -0300, Marcelo Ricardo Leitner wrote: > > On Thu, May 28, 2015 at 08:17:27AM -0300, Marcelo Ricardo Leitner wrote: > > > On Thu, May 28, 2015 at 06:15:11AM -0400, Neil Horman wrote: > > > >

Re: [PATCH] sctp: fix ASCONF list handling

2015-05-28 Thread Marcelo Ricardo Leitner
On Thu, May 28, 2015 at 10:27:32AM -0300, Marcelo Ricardo Leitner wrote: > On Thu, May 28, 2015 at 08:17:27AM -0300, Marcelo Ricardo Leitner wrote: > > On Thu, May 28, 2015 at 06:15:11AM -0400, Neil Horman wrote: > > > On Wed, May 27, 2015 at 09:52:17PM -0300, mleit...@redhat.com wrote: > > > > Fro

Re: [PATCH] sctp: fix ASCONF list handling

2015-05-28 Thread Neil Horman
On Thu, May 28, 2015 at 10:27:32AM -0300, Marcelo Ricardo Leitner wrote: > On Thu, May 28, 2015 at 08:17:27AM -0300, Marcelo Ricardo Leitner wrote: > > On Thu, May 28, 2015 at 06:15:11AM -0400, Neil Horman wrote: > > > On Wed, May 27, 2015 at 09:52:17PM -0300, mleit...@redhat.com wrote: > > > > Fro

Re: [PATCH] sctp: fix ASCONF list handling

2015-05-28 Thread Marcelo Ricardo Leitner
On Thu, May 28, 2015 at 08:17:27AM -0300, Marcelo Ricardo Leitner wrote: > On Thu, May 28, 2015 at 06:15:11AM -0400, Neil Horman wrote: > > On Wed, May 27, 2015 at 09:52:17PM -0300, mleit...@redhat.com wrote: > > > From: Marcelo Ricardo Leitner > > > > > > ->auto_asconf_splist is per namespace an

Re: [PATCH] sctp: fix ASCONF list handling

2015-05-28 Thread Marcelo Ricardo Leitner
On Thu, May 28, 2015 at 06:15:11AM -0400, Neil Horman wrote: > On Wed, May 27, 2015 at 09:52:17PM -0300, mleit...@redhat.com wrote: > > From: Marcelo Ricardo Leitner > > > > ->auto_asconf_splist is per namespace and mangled by functions like > > sctp_setsockopt_auto_asconf() which doesn't guarant

Re: [PATCH] sctp: fix ASCONF list handling

2015-05-28 Thread Neil Horman
On Wed, May 27, 2015 at 09:52:17PM -0300, mleit...@redhat.com wrote: > From: Marcelo Ricardo Leitner > > ->auto_asconf_splist is per namespace and mangled by functions like > sctp_setsockopt_auto_asconf() which doesn't guarantee any serialization. > > Also, the call to inet_sk_copy_descendant()

[PATCH] sctp: fix ASCONF list handling

2015-05-27 Thread mleitner
From: Marcelo Ricardo Leitner ->auto_asconf_splist is per namespace and mangled by functions like sctp_setsockopt_auto_asconf() which doesn't guarantee any serialization. Also, the call to inet_sk_copy_descendant() was backuping ->auto_asconf_list through the copy but was not honoring ->do_auto_