Re: [PATCH] select: fix sys_select to not leak ERESTARTNOHAND to userspace

2007-01-23 Thread Neil Horman
On Tue, Jan 23, 2007 at 10:02:49AM +1100, Andi Kleen wrote: > On Tuesday 23 January 2007 00:00, Neil Horman wrote: > > As it is currently written, sys_select checks its return code to convert > > ERESTARTNOHAND to EINTR. However, the check is within an if (tvp) clause, > > and so if select is call

Re: [PATCH] select: fix sys_select to not leak ERESTARTNOHAND to userspace

2007-01-22 Thread Andi Kleen
On Tuesday 23 January 2007 00:00, Neil Horman wrote: > As it is currently written, sys_select checks its return code to convert > ERESTARTNOHAND to EINTR. However, the check is within an if (tvp) clause, > and so if select is called from userspace with a NULL timeval, then it is > possible for the

[PATCH] select: fix sys_select to not leak ERESTARTNOHAND to userspace

2007-01-22 Thread Neil Horman
As it is currently written, sys_select checks its return code to convert ERESTARTNOHAND to EINTR. However, the check is within an if (tvp) clause, and so if select is called from userspace with a NULL timeval, then it is possible for the ERESTARTNOHAND errno to leak into userspace, which is incorr