Re: [PATCH] sis900: Allocate rx replacement buffer before rx operation

2007-04-28 Thread Neil Horman
> >diff --git a/drivers/net/sis900.c b/drivers/net/sis900.c > >index a6a0f09..7e44939 100644 > >--- a/drivers/net/sis900.c > >+++ b/drivers/net/sis900.c > >@@ -1754,6 +1754,7 @@ static int sis900_rx(struct net_device *net_dev) > > sis_priv->rx_ring[entry].cmdsts = RX_BUF_SIZE; >

Re: [PATCH] sis900: Allocate rx replacement buffer before rx operation

2007-04-27 Thread Jeff Garzik
Neil Horman wrote: On Tue, Apr 24, 2007 at 12:43:20PM -0400, Jeff Garzik wrote: Neil Horman wrote: Hey there- The sis900 driver appears to have a bug in which the receive routine passes the skbuff holding the received frame to the network stack before refilling the buffer in the rx ring

Re: [PATCH] sis900: Allocate rx replacement buffer before rx operation

2007-04-26 Thread Neil Horman
On Thu, Apr 26, 2007 at 01:47:36PM -0400, Neil Horman wrote: > On Tue, Apr 24, 2007 at 12:43:20PM -0400, Jeff Garzik wrote: > > Neil Horman wrote: > > >Hey there- > > > The sis900 driver appears to have a bug in which the receive routine > > >passes the skbuff holding the received frame to the ne

Re: [PATCH] sis900: Allocate rx replacement buffer before rx operation

2007-04-26 Thread Neil Horman
On Tue, Apr 24, 2007 at 12:43:20PM -0400, Jeff Garzik wrote: > Neil Horman wrote: > >Hey there- > > The sis900 driver appears to have a bug in which the receive routine > >passes the skbuff holding the received frame to the network stack before > >refilling the buffer in the rx ring. If a new

Re: [PATCH] sis900: Allocate rx replacement buffer before rx operation

2007-04-24 Thread Jeff Garzik
Neil Horman wrote: Hey there- The sis900 driver appears to have a bug in which the receive routine passes the skbuff holding the received frame to the network stack before refilling the buffer in the rx ring. If a new skbuff cannot be allocated, the driver simply leaves a hole in the rx

Re: [PATCH] sis900: Allocate rx replacement buffer before rx operation

2007-04-20 Thread Daniele Venzano
Il giorno 20/apr/07, alle ore 15:54, Neil Horman ha scritto: Hey there- The sis900 driver appears to have a bug in which the receive routine passes the skbuff holding the received frame to the network stack before refilling the buffer in the rx ring. If a new skbuff cannot be alloc

Re: [PATCH] sis900: Allocate rx replacement buffer before rx operation

2007-04-20 Thread Jeff Garzik
Neil Horman wrote: Hey there- The sis900 driver appears to have a bug in which the receive routine passes the skbuff holding the received frame to the network stack before refilling the buffer in the rx ring. If a new skbuff cannot be allocated, the driver simply leaves a hole in the rx

[PATCH] sis900: Allocate rx replacement buffer before rx operation

2007-04-20 Thread Neil Horman
Hey there- The sis900 driver appears to have a bug in which the receive routine passes the skbuff holding the received frame to the network stack before refilling the buffer in the rx ring. If a new skbuff cannot be allocated, the driver simply leaves a hole in the rx ring, which causes th