Re: [PATCH] speed up __alloc_skb

2006-01-03 Thread David S. Miller
From: Benjamin LaHaise <[EMAIL PROTECTED]> Date: Fri, 16 Dec 2005 14:52:01 -0500 > In __alloc_skb(), the use of skb_shinfo() which casts a u8 * to the > shared info structure results in gcc being forced to do a reload of the > pointer since it has no information on possible aliasing. Fix this b

Re: [PATCH] speed up __alloc_skb

2005-12-19 Thread David S. Miller
From: Christoph Hellwig <[EMAIL PROTECTED]> Date: Sat, 17 Dec 2005 12:50:28 + > The Xen networking stuff is a piece of crap currently and far a way from > beeing mergeable. I think we should kill it and if Xen still needs it after > their networking code is rewritten to something sane we can

Re: [PATCH] speed up __alloc_skb

2005-12-17 Thread Christoph Hellwig
On Fri, Dec 16, 2005 at 02:34:28PM -0800, David S. Miller wrote: > From: Benjamin LaHaise <[EMAIL PROTECTED]> > Date: Fri, 16 Dec 2005 15:58:57 -0500 > > > On Fri, Dec 16, 2005 at 12:59:57PM -0800, Joe Perches wrote: > > > How about moving this into a helper function > > > and calling it from allo

Re: [PATCH] speed up __alloc_skb

2005-12-16 Thread David S. Miller
From: Benjamin LaHaise <[EMAIL PROTECTED]> Date: Fri, 16 Dec 2005 15:58:57 -0500 > On Fri, Dec 16, 2005 at 12:59:57PM -0800, Joe Perches wrote: > > How about moving this into a helper function > > and calling it from alloc_skb_from_cache too? > > The previous patch deleted alloc_skb_from_cache(),

RE: [PATCH] speed up __alloc_skb

2005-12-16 Thread Ian Pratt
> On Fri, 2005-12-16 at 15:58 -0500, Benjamin LaHaise wrote: > > On Fri, Dec 16, 2005 at 12:59:57PM -0800, Joe Perches wrote: > > > How about moving this into a helper function and calling it from > > > alloc_skb_from_cache too? > > > > The previous patch deleted alloc_skb_from_cache(), which wa

Re: [PATCH] speed up __alloc_skb

2005-12-16 Thread Joe Perches
On Fri, 2005-12-16 at 15:58 -0500, Benjamin LaHaise wrote: > On Fri, Dec 16, 2005 at 12:59:57PM -0800, Joe Perches wrote: > > How about moving this into a helper function > > and calling it from alloc_skb_from_cache too? > > The previous patch deleted alloc_skb_from_cache(), which wasn't reference

Re: [PATCH] speed up __alloc_skb

2005-12-16 Thread Benjamin LaHaise
On Fri, Dec 16, 2005 at 12:59:57PM -0800, Joe Perches wrote: > How about moving this into a helper function > and calling it from alloc_skb_from_cache too? The previous patch deleted alloc_skb_from_cache(), which wasn't referenced from anywhere in the tree. -ben - To unsubscribe

Re: [PATCH] speed up __alloc_skb

2005-12-16 Thread Joe Perches
On Fri, 2005-12-16 at 14:52 -0500, Benjamin LaHaise wrote: > In __alloc_skb(), the use of skb_shinfo() which casts a u8 * to the > shared info structure results in gcc being forced to do a reload of the > pointer since it has no information on possible aliasing. Fix this by > using a pointer to

[PATCH] speed up __alloc_skb

2005-12-16 Thread Benjamin LaHaise
In __alloc_skb(), the use of skb_shinfo() which casts a u8 * to the shared info structure results in gcc being forced to do a reload of the pointer since it has no information on possible aliasing. Fix this by using a pointer to refer to skb_shared_info. By initializing skb_shared_info sequent