Re: [PATCH] stmmac: call local_irq_save other than disable_irq in poll_controller

2015-05-06 Thread David Miller
From: Sonic Zhang Date: Wed, 6 May 2015 11:53:53 +0800 > When I debug Linux kernel via KGDB over Ethernet, KGDB calls netpoll > API and stmmac_poll_controller to send UDP packets with all interrupts > disabled. KGDB assumes all interrupts keeps disabled when it is active > and doing UDP data tran

Re: [PATCH] stmmac: call local_irq_save other than disable_irq in poll_controller

2015-05-05 Thread Sonic Zhang
Hi David, On Wed, May 6, 2015 at 7:36 AM, David Miller wrote: > From: Sonic Zhang > Date: Tue, 5 May 2015 15:55:53 +0800 > >> From: Sonic Zhang >> >> It is possible that poll_controller is called from netpoll.c with irq >> already disabled. Unexpected interrupt may be triggered if always >> ena

Re: [PATCH] stmmac: call local_irq_save other than disable_irq in poll_controller

2015-05-05 Thread David Miller
From: Sonic Zhang Date: Tue, 5 May 2015 15:55:53 +0800 > From: Sonic Zhang > > It is possible that poll_controller is called from netpoll.c with irq > already disabled. Unexpected interrupt may be triggered if always > enable irq before returning from poll_controller. > > Signed-off-by: Sonic