Re: [PATCH] ucc_geth: Reset BQL queue when stopping device

2019-01-30 Thread David Miller
From: Mathias Thore Date: Mon, 28 Jan 2019 10:07:47 +0100 > After a timeout event caused by for example a broadcast storm, when > the MAC and PHY are reset, the BQL TX queue needs to be reset as > well. Otherwise, the device will exhibit severe performance issues > even after the storm has ended.

Re: [PATCH] ucc_geth: Reset BQL queue when stopping device

2019-01-29 Thread David Miller
From: Mathias Thore Date: Tue, 29 Jan 2019 08:07:54 + > Is there a scenario where we are clearing the TX ring but don't want to reset > the BQL TX queue? > > I think it makes sense to keep it in ucc_geth_free_tx since the > reason it is needed isn't the timeout per se, but rather the > clea

Re: [PATCH] ucc_geth: Reset BQL queue when stopping device

2019-01-29 Thread Li Yang
c-...@lists.ozlabs.org; David Gounaris ; > Joakim Tjernlund > Subject: Re: [PATCH] ucc_geth: Reset BQL queue when stopping device > > On Mon, Jan 28, 2019 at 8:37 AM Mathias Thore > wrote: > > > > Hi, > > > > > > This is what we observed: there was

RE: [PATCH] ucc_geth: Reset BQL queue when stopping device

2019-01-29 Thread Mathias Thore
t; > -- > > > From: Christophe Leroy > Sent: Monday, January 28, 2019 10:48 AM > To: Mathias Thore; leoyang...@nxp.com; netdev@vger.kernel.org; > linuxppc-...@lists.ozlabs.org; David Gounaris; Joakim Tjernlund > Subject: Re: [PATCH] ucc_geth: Reset BQL queue when stopping de

Re: [PATCH] ucc_geth: Reset BQL queue when stopping device

2019-01-28 Thread Li Yang
Monday, January 28, 2019 10:48 AM > To: Mathias Thore; leoyang...@nxp.com; netdev@vger.kernel.org; > linuxppc-...@lists.ozlabs.org; David Gounaris; Joakim Tjernlund > Subject: Re: [PATCH] ucc_geth: Reset BQL queue when stopping device > > > CAUTION: This email originated from out

Re: [PATCH] ucc_geth: Reset BQL queue when stopping device

2019-01-28 Thread Mathias Thore
; linuxppc-...@lists.ozlabs.org; David Gounaris; Joakim Tjernlund Subject: Re: [PATCH] ucc_geth: Reset BQL queue when stopping device   CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe

Re: [PATCH] ucc_geth: Reset BQL queue when stopping device

2019-01-28 Thread Christophe Leroy
Hi, Le 28/01/2019 à 10:07, Mathias Thore a écrit : After a timeout event caused by for example a broadcast storm, when the MAC and PHY are reset, the BQL TX queue needs to be reset as well. Otherwise, the device will exhibit severe performance issues even after the storm has ended. What are th

[PATCH] ucc_geth: Reset BQL queue when stopping device

2019-01-28 Thread Mathias Thore
After a timeout event caused by for example a broadcast storm, when the MAC and PHY are reset, the BQL TX queue needs to be reset as well. Otherwise, the device will exhibit severe performance issues even after the storm has ended. Co-authored-by: David Gounaris Signed-off-by: Mathias Thore ---