[PATCH] veth: Cleanly handle a missing peer_tb argument on creation.

2007-09-12 Thread Eric W. Biederman
I was getting strange kernel crashes when attempting to create veth devices when I did not specify a peer argument to /bin/ip. So this patch defaults peer_tb to all zeros and doesn't attempt to reuse the netlink attributes for the primary link to create the secondary link and now I can't reproduc

Re: [PATCH] veth: Cleanly handle a missing peer_tb argument on creation.

2007-09-12 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Wed, 12 Sep 2007 07:19:56 -0600 > > I was getting strange kernel crashes when attempting to > create veth devices when I did not specify a peer argument > to /bin/ip. > > So this patch defaults peer_tb to all zeros and doesn't attempt to > reuse

Re: [PATCH] veth: Cleanly handle a missing peer_tb argument on creation.

2007-09-12 Thread Pavel Emelyanov
Eric W. Biederman wrote: > I was getting strange kernel crashes when attempting to > create veth devices when I did not specify a peer argument > to /bin/ip. > > So this patch defaults peer_tb to all zeros and doesn't attempt to > reuse the netlink attributes for the primary link to create the > s

Re: [PATCH] veth: Cleanly handle a missing peer_tb argument on creation.

2007-09-12 Thread Eric W. Biederman
Pavel Emelyanov <[EMAIL PROTECTED]> writes: >> +} >> >> -tbp = peer_tb; >> -} else >> -tbp = tb; > > The intention of this part was to get the same parameters for > peer as for the first device if no "peer" argument was specified > for ip utility. Does it still wo

Re: [PATCH] veth: Cleanly handle a missing peer_tb argument on creation.

2007-09-12 Thread Pavel Emelyanov
Eric W. Biederman wrote: > Pavel Emelyanov <[EMAIL PROTECTED]> writes: > >>> + } >>> >>> - tbp = peer_tb; >>> - } else >>> - tbp = tb; >> The intention of this part was to get the same parameters for >> peer as for the first device if no "peer" argument was specified >> f

Re: [PATCH] veth: Cleanly handle a missing peer_tb argument on creation.

2007-09-12 Thread Eric W. Biederman
Pavel Emelyanov <[EMAIL PROTECTED]> writes: > Eric W. Biederman wrote: >> Pavel Emelyanov <[EMAIL PROTECTED]> writes: >> + } - tbp = peer_tb; - } else - tbp = tb; >>> The intention of this part was to get the same parameters for >>> peer as for the f

Re: [PATCH] veth: Cleanly handle a missing peer_tb argument on creation.

2007-09-12 Thread Pavel Emelyanov
Eric W. Biederman wrote: > Pavel Emelyanov <[EMAIL PROTECTED]> writes: > >> Eric W. Biederman wrote: >>> Pavel Emelyanov <[EMAIL PROTECTED]> writes: >>> > + } > > - tbp = peer_tb; > - } else > - tbp = tb; The intention of this part was to get the same par

Re: [PATCH] veth: Cleanly handle a missing peer_tb argument on creation.

2007-09-13 Thread Pavel Emelyanov
Eric W. Biederman wrote: > Pavel Emelyanov <[EMAIL PROTECTED]> writes: > >> Eric W. Biederman wrote: >>> Pavel Emelyanov <[EMAIL PROTECTED]> writes: >>> > + } > > - tbp = peer_tb; > - } else > - tbp = tb; The intention of this part was to get the same par