Re: [PATCH] vhost-net: add time limitation for tx polling(Internet mail)

2018-03-28 Thread Jason Wang
On 2018年03月28日 23:31, Michael S. Tsirkin wrote: On Wed, Mar 28, 2018 at 02:37:04PM +0800, Jason Wang wrote: On 2018年03月28日 12:01, haibinzhang(张海斌) wrote: On 2018年03月27日 19:26, Jason wrote On 2018年03月27日 17:12, haibinzhang wrote: handle_tx() will delay rx for a long time when busy tx polling

Re: [PATCH] vhost-net: add time limitation for tx polling(Internet mail)

2018-03-28 Thread Michael S. Tsirkin
On Wed, Mar 28, 2018 at 02:37:04PM +0800, Jason Wang wrote: > > > On 2018年03月28日 12:01, haibinzhang(张海斌) wrote: > > On 2018年03月27日 19:26, Jason wrote > > On 2018年03月27日 17:12, haibinzhang wrote: > > > > handle_tx() will delay rx for a long time when busy tx polling udp > > > > packets > > > > wi

Re: [PATCH] vhost-net: add time limitation for tx polling(Internet mail)

2018-03-27 Thread Jason Wang
On 2018年03月28日 12:01, haibinzhang(张海斌) wrote: On 2018年03月27日 19:26, Jason wrote On 2018年03月27日 17:12, haibinzhang wrote: handle_tx() will delay rx for a long time when busy tx polling udp packets with short length(ie: 1byte udp payload), because setting VHOST_NET_WEIGHT takes into account only

Re: [PATCH] vhost-net: add time limitation for tx polling(Internet mail)

2018-03-27 Thread 张海斌
On 2018年03月27日 19:26, Jason wrote On 2018年03月27日 17:12, haibinzhang wrote: >> handle_tx() will delay rx for a long time when busy tx polling udp packets >> with short length(ie: 1byte udp payload), because setting VHOST_NET_WEIGHT >> takes into account only sent-bytes but no time. > >Interesting. >

Re: [PATCH] vhost-net: add time limitation for tx polling

2018-03-27 Thread Jason Wang
On 2018年03月27日 17:12, haibinzhang(张海斌) wrote: handle_tx() will delay rx for a long time when busy tx polling udp packets with short length(ie: 1byte udp payload), because setting VHOST_NET_WEIGHT takes into account only sent-bytes but no time. Interesting. Looking at vhost_can_busy_poll() it

[PATCH] vhost-net: add time limitation for tx polling

2018-03-27 Thread 张海斌
handle_tx() will delay rx for a long time when busy tx polling udp packets with short length(ie: 1byte udp payload), because setting VHOST_NET_WEIGHT takes into account only sent-bytes but no time. It's not fair for handle_rx(), so needs to limit max time of tx polling. Signed-off-by: Haibin Zhang