Commit 0b50dc4fc971 ("Convert smsc911x to use ACPI as well as DT") makes
the call to smsc911x_probe_config() unconditional, and no longer fails if
there is no device node. device_get_phy_mode() is called unconditionally,
and if there is no phy node configured returns an error code. This error
code
From: Guenter Roeck
Date: Mon, 17 Aug 2015 13:45:36 -0700
> Commit 0b50dc4fc971 ("Convert smsc911x to use ACPI as well as DT") makes
> the call to smsc911x_probe_config() unconditional, and no longer fails if
> there is no device node. device_get_phy_mode() is called unconditionally,
> and if the
On 08/17/2015 03:45 PM, Guenter Roeck wrote:
Commit 0b50dc4fc971 ("Convert smsc911x to use ACPI as well as DT") makes
the call to smsc911x_probe_config() unconditional, and no longer fails if
there is no device node. device_get_phy_mode() is called unconditionally,
and if there is no phy node con
On 08/17/2015 02:19 PM, Jeremy Linton wrote:
On 08/17/2015 03:45 PM, Guenter Roeck wrote:
Commit 0b50dc4fc971 ("Convert smsc911x to use ACPI as well as DT") makes
the call to smsc911x_probe_config() unconditional, and no longer fails if
there is no device node. device_get_phy_mode() is called un
On 08/17/2015 05:14 PM, Guenter Roeck wrote:
One nitpick I noticed after sending my patch: dev can never be NULL in
smsc911x_probe_config(), so it does not really make sense to check if it is
NULL.
No, it doesn't... it should really be something like
if (dev_fwnode(dev))
But dev_fwnode is st
Hi,
* Guenter Roeck [150817 13:48]:
> Commit 0b50dc4fc971 ("Convert smsc911x to use ACPI as well as DT") makes
> the call to smsc911x_probe_config() unconditional, and no longer fails if
> there is no device node. device_get_phy_mode() is called unconditionally,
> and if there is no phy node conf
On 08/26/2015 12:04 PM, Tony Lindgren wrote:
* Guenter Roeck [150817 13:48]:
Commit 0b50dc4fc971 ("Convert smsc911x to use ACPI as well as DT") makes
Looks like this change makes at least omap boards using smsc911x
fail with -22 for me in Linux next.
Do any of the the device tree configured s
Hi Tony,
On 08/26/2015 10:04 AM, Tony Lindgren wrote:
Hi,
* Guenter Roeck [150817 13:48]:
Commit 0b50dc4fc971 ("Convert smsc911x to use ACPI as well as DT") makes
the call to smsc911x_probe_config() unconditional, and no longer fails if
there is no device node. device_get_phy_mode() is called
* Jeremy Linton [150826 10:35]:
> On 08/26/2015 12:04 PM, Tony Lindgren wrote:
> >* Guenter Roeck [150817 13:48]:
> >>Commit 0b50dc4fc971 ("Convert smsc911x to use ACPI as well as DT") makes
> >Looks like this change makes at least omap boards using smsc911x
> >fail with -22 for me in Linux next.
* Guenter Roeck [150826 10:40]:
> Hi Tony,
>
> On 08/26/2015 10:04 AM, Tony Lindgren wrote:
> >Hi,
> >
> >* Guenter Roeck [150817 13:48]:
> >>Commit 0b50dc4fc971 ("Convert smsc911x to use ACPI as well as DT") makes
> >>the call to smsc911x_probe_config() unconditional, and no longer fails if
> >
On 08/26/2015 10:04 AM, Tony Lindgren wrote:
Hi,
* Guenter Roeck [150817 13:48]:
Commit 0b50dc4fc971 ("Convert smsc911x to use ACPI as well as DT") makes
the call to smsc911x_probe_config() unconditional, and no longer fails if
there is no device node. device_get_phy_mode() is called unconditi
* Guenter Roeck [150826 11:37]:
> On 08/26/2015 10:04 AM, Tony Lindgren wrote:
> >Hi,
> >
> >* Guenter Roeck [150817 13:48]:
> >>Commit 0b50dc4fc971 ("Convert smsc911x to use ACPI as well as DT") makes
> >>the call to smsc911x_probe_config() unconditional, and no longer fails if
> >>there is no d
Hi Tony,
On 08/26/2015 01:16 PM, Tony Lindgren wrote:
[ ... ]
We may need two separate patches, one to fix up device_property_read_u32()
to return -ENXIO, and one to fix smsc911x_probe_config() to ignore the error
from device_get_phy_mode(), and to bail out if device_property_read_u32()
returns
* Guenter Roeck [150826 13:58]:
> Hi Tony,
>
> On 08/26/2015 01:16 PM, Tony Lindgren wrote:
> [ ... ]
>
> >>We may need two separate patches, one to fix up device_property_read_u32()
> >>to return -ENXIO, and one to fix smsc911x_probe_config() to ignore the error
> >>from device_get_phy_mode(),
14 matches
Mail list logo