Re: [PATCH -next 2/3] tcp: send_reset: test for non-NULL sk first

2015-12-22 Thread Hannes Frederic Sowa
On 21.12.2015 21:29, Florian Westphal wrote: > tcp_md5_do_lookup requires a full socket, so once we extend > _send_reset() to also accept timewait socket we would have to change > > if (!sk && hash_location) > > to something like > > if ((!sk || !sk_fullsock(sk)) && hash_location) { > ... > }

Re: [PATCH -next 2/3] tcp: send_reset: test for non-NULL sk first

2015-12-22 Thread Eric Dumazet
On Mon, 2015-12-21 at 21:29 +0100, Florian Westphal wrote: > tcp_md5_do_lookup requires a full socket, so once we extend > _send_reset() to also accept timewait socket we would have to change > Acked-by: Eric Dumazet -- To unsubscribe from this list: send the line "unsubscribe netdev" in the b

[PATCH -next 2/3] tcp: send_reset: test for non-NULL sk first

2015-12-21 Thread Florian Westphal
tcp_md5_do_lookup requires a full socket, so once we extend _send_reset() to also accept timewait socket we would have to change if (!sk && hash_location) to something like if ((!sk || !sk_fullsock(sk)) && hash_location) { ... } else { (sk && sk_fullsock(sk)) tcp_md5_do_lookup() } Switch th