On Tue, 6 Feb 2018, Dan Carpenter wrote:
> That found 4 that I think Wolfram's grep missed.
>
> arch/um/drivers/vector_user.h |2 --
> drivers/gpu/drm/mxsfb/mxsfb_regs.h|2 --
> drivers/video/fbdev/mxsfb.c |2 --
> include/drm/drm_scdc_helper.h
That found 4 that I think Wolfram's grep missed.
arch/um/drivers/vector_user.h |2 --
drivers/gpu/drm/mxsfb/mxsfb_regs.h|2 --
drivers/video/fbdev/mxsfb.c |2 --
include/drm/drm_scdc_helper.h |3 ---
But it didn't find the two bugs tha
> I did that too but got no results. Perhaps right shifting constants is
> pretty uncommon. I can put that in the complete rule though.
Please do. Even if rare, we would want this bug pointed out, right? :)
signature.asc
Description: PGP signature
On Tue, 6 Feb 2018, Wolfram Sang wrote:
> Hi Julia,
>
> > and got the results below. I can make a version for the kernel shortly.
>
> It should probably take care of right-shifting, too?
I did that too but got no results. Perhaps right shifting constants is
pretty uncommon. I can put that in
Hi Julia,
> and got the results below. I can make a version for the kernel shortly.
It should probably take care of right-shifting, too?
Thanks,
Wolfram
signature.asc
Description: PGP signature
On Tue, 6 Feb 2018, Dan Carpenter wrote:
> On Tue, Feb 06, 2018 at 02:15:51PM +0100, Julia Lawall wrote:
> >
> >
> > On Tue, 6 Feb 2018, Dan Carpenter wrote:
> >
> > > On Mon, Feb 05, 2018 at 09:09:57PM +0100, Wolfram Sang wrote:
> > > > In one Renesas driver, I found a typo which turned an inte
On Tue, Feb 06, 2018 at 02:15:51PM +0100, Julia Lawall wrote:
>
>
> On Tue, 6 Feb 2018, Dan Carpenter wrote:
>
> > On Mon, Feb 05, 2018 at 09:09:57PM +0100, Wolfram Sang wrote:
> > > In one Renesas driver, I found a typo which turned an intended bit shift
> > > ('<<')
> > > into a comparison ('
On Tue, 6 Feb 2018, Dan Carpenter wrote:
> On Mon, Feb 05, 2018 at 09:09:57PM +0100, Wolfram Sang wrote:
> > In one Renesas driver, I found a typo which turned an intended bit shift
> > ('<<')
> > into a comparison ('<'). Because this is a subtle issue, I looked tree wide
> > for
> > similar p
On Mon, Feb 05, 2018 at 09:09:57PM +0100, Wolfram Sang wrote:
> In one Renesas driver, I found a typo which turned an intended bit shift
> ('<<')
> into a comparison ('<'). Because this is a subtle issue, I looked tree wide
> for
> similar patterns. This small patch series is the outcome.
>
> Bu
> I found two more using "git grep 'define.*0x[0-9a-f]* < '":
I added '[0-9]\+' at the end of the regex to reduce the number of false
positives...
> drivers/net/can/m_can/m_can.c:#define RXFC_FWM_MASK (0x7f <
> RXFC_FWM_SHIFT)
> drivers/usb/gadget/udc/goku_udc.h:#define INT_EPnNAK(n)
> (0x0
Hi Wolfram,
On Mon, Feb 5, 2018 at 9:09 PM, Wolfram Sang
wrote:
> In one Renesas driver, I found a typo which turned an intended bit shift
> ('<<')
> into a comparison ('<'). Because this is a subtle issue, I looked tree wide
> for
> similar patterns. This small patch series is the outcome.
>
>
In one Renesas driver, I found a typo which turned an intended bit shift ('<<')
into a comparison ('<'). Because this is a subtle issue, I looked tree wide for
similar patterns. This small patch series is the outcome.
Buildbot and checkpatch are happy. Only compile-tested. To be applied
individual
12 matches
Mail list logo