Re: [PATCH 0/5] Make nicer CONFIG_NET_NS=n case code

2007-11-01 Thread Eric Dumazet
Eric W. Biederman a écrit : Eric Dumazet [EMAIL PROTECTED] writes: Eric W. Biederman a écrit : Eric Dumazet [EMAIL PROTECTED] writes: Definitly wanted here. Thank you. One more refcounting on each socket creation/deletion was expensive. Really? Have you actually measured that? If the

Re: [PATCH 0/5] Make nicer CONFIG_NET_NS=n case code

2007-11-01 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Thu, 01 Nov 2007 07:58:59 +0100 I agree with you that with current state, this atomic_inc/atomic_dec_and_test wont come in profiles unless a trivial bench is writen for(;;){close(socket());} Just add one packet send and one packet receive in

[PATCH 0/5] Make nicer CONFIG_NET_NS=n case code

2007-10-31 Thread Pavel Emelyanov
Currently we have the NET_NS config option, but the only change it makes is just return ERR_PTR(-EINVAL) inside the cloning call thus introducing a bunch of a dead code and making the reference counting unneeded. This is not very good. So clean the net_namespace.c to fix this. I have sent a set

Re: [PATCH 0/5] Make nicer CONFIG_NET_NS=n case code

2007-10-31 Thread Eric Dumazet
On Wed, 31 Oct 2007 22:19:43 +0300 Pavel Emelyanov [EMAIL PROTECTED] wrote: Currently we have the NET_NS config option, but the only change it makes is just return ERR_PTR(-EINVAL) inside the cloning call thus introducing a bunch of a dead code and making the reference counting unneeded.

Re: [PATCH 0/5] Make nicer CONFIG_NET_NS=n case code

2007-10-31 Thread Daniel Lezcano
Eric Dumazet wrote: On Wed, 31 Oct 2007 22:19:43 +0300 Pavel Emelyanov [EMAIL PROTECTED] wrote: Currently we have the NET_NS config option, but the only change it makes is just return ERR_PTR(-EINVAL) inside the cloning call thus introducing a bunch of a dead code and making the reference

Re: [PATCH 0/5] Make nicer CONFIG_NET_NS=n case code

2007-10-31 Thread Daniel Lezcano
Pavel Emelyanov wrote: Currently we have the NET_NS config option, but the only change it makes is just return ERR_PTR(-EINVAL) inside the cloning call thus introducing a bunch of a dead code and making the reference counting unneeded. This is not very good. So clean the net_namespace.c to fix

Re: [PATCH 0/5] Make nicer CONFIG_NET_NS=n case code

2007-10-31 Thread Eric W. Biederman
Eric Dumazet [EMAIL PROTECTED] writes: Definitly wanted here. Thank you. One more refcounting on each socket creation/deletion was expensive. Really? Have you actually measured that? If the overhead is measurable and expensive we may want to look at per cpu counters or something like that.

Re: [PATCH 0/5] Make nicer CONFIG_NET_NS=n case code

2007-10-31 Thread Eric Dumazet
Eric W. Biederman a écrit : Eric Dumazet [EMAIL PROTECTED] writes: Definitly wanted here. Thank you. One more refcounting on each socket creation/deletion was expensive. Really? Have you actually measured that? If the overhead is measurable and expensive we may want to look at per cpu

Re: [PATCH 0/5] Make nicer CONFIG_NET_NS=n case code

2007-10-31 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Wed, 31 Oct 2007 23:40:59 +0100 Eric W. Biederman a écrit : Eric Dumazet [EMAIL PROTECTED] writes: Definitly wanted here. Thank you. One more refcounting on each socket creation/deletion was expensive. Really? Have you actually

Re: [PATCH 0/5] Make nicer CONFIG_NET_NS=n case code

2007-10-31 Thread Eric W. Biederman
Eric Dumazet [EMAIL PROTECTED] writes: Eric W. Biederman a écrit : Eric Dumazet [EMAIL PROTECTED] writes: Definitly wanted here. Thank you. One more refcounting on each socket creation/deletion was expensive. Really? Have you actually measured that? If the overhead is measurable and

Re: [PATCH 0/5] Make nicer CONFIG_NET_NS=n case code

2007-10-31 Thread Eric W. Biederman
David Miller [EMAIL PROTECTED] writes: From: Eric Dumazet [EMAIL PROTECTED] Date: Wed, 31 Oct 2007 23:40:59 +0100 Eric W. Biederman a écrit : Eric Dumazet [EMAIL PROTECTED] writes: Definitly wanted here. Thank you. One more refcounting on each socket creation/deletion was