Re: [PATCH 00/10 net-next] net/tipc: fix all kernel-doc and add TIPC networking chapter

2020-11-29 Thread Randy Dunlap
On 11/28/20 11:37 PM, Ying Xue wrote: > On 11/25/20 12:20 PM, Randy Dunlap wrote: >> >> Question: is net/tipc/discover.c, in tipc_disc_delete() kernel-doc, >> what is the word "duest"? Should it be changed? > > The "duest" is a typo, and it should be "dest" defined as below: > struct tipc_discove

Re: [PATCH 00/10 net-next] net/tipc: fix all kernel-doc and add TIPC networking chapter

2020-11-28 Thread Ying Xue
On 11/25/20 12:20 PM, Randy Dunlap wrote: > > Question: is net/tipc/discover.c, in tipc_disc_delete() kernel-doc, > what is the word "duest"? Should it be changed? The "duest" is a typo, and it should be "dest" defined as below: struct tipc_discoverer { u32 bearer_id; struct tipc

Re: [PATCH 00/10 net-next] net/tipc: fix all kernel-doc and add TIPC networking chapter

2020-11-27 Thread Jakub Kicinski
On Tue, 24 Nov 2020 20:20:16 -0800 Randy Dunlap wrote: > Fix lots of net/tipc/ kernel-doc warnings. Add many struct field and > function parameter descriptions. > > Then add a TIPC chapter to the networking documentation book. > > > Note: some of the struct members and function parameters are ma

[PATCH 00/10 net-next] net/tipc: fix all kernel-doc and add TIPC networking chapter

2020-11-24 Thread Randy Dunlap
Fix lots of net/tipc/ kernel-doc warnings. Add many struct field and function parameter descriptions. Then add a TIPC chapter to the networking documentation book. Note: some of the struct members and function parameters are marked with "FIXME". They could use some additional descriptions if som