Re: [PATCH 02/31] fs: add new vfs_poll and file_can_poll helpers

2018-01-08 Thread Christoph Hellwig
On Sat, Jan 06, 2018 at 07:08:53PM +, Al Viro wrote: > On Thu, Jan 04, 2018 at 09:00:14AM +0100, Christoph Hellwig wrote: > > These abstract out calls to the poll method in preparation for changes to > > those methods. > > FWIW, I would make vfs_poll() > > static inline __poll_t

Re: [PATCH 02/31] fs: add new vfs_poll and file_can_poll helpers

2018-01-06 Thread Al Viro
On Thu, Jan 04, 2018 at 09:00:14AM +0100, Christoph Hellwig wrote: > These abstract out calls to the poll method in preparation for changes to > those methods. FWIW, I would make vfs_poll() static inline __poll_t vfs_poll(struct file *file, struct poll_table_struct *pt) { if

[PATCH 02/31] fs: add new vfs_poll and file_can_poll helpers

2018-01-04 Thread Christoph Hellwig
These abstract out calls to the poll method in preparation for changes to those methods. Signed-off-by: Christoph Hellwig --- drivers/staging/comedi/drivers/serial2002.c | 4 ++-- drivers/vfio/virqfd.c | 2 +- drivers/vhost/vhost.c | 2