Re: [PATCH 05/11] net: stmmac: dwmac-rk: Add internal phy support

Hi Andrew, 在 2017/6/24 10:29, Andrew Lunn 写道: If this is the PHY clock, should it actually be specified in the PHY binding? Can you read the PHY ID registers with this clock off? If the phy clock is closed, we can not read the PHYID.

Re: [PATCH 05/11] net: stmmac: dwmac-rk: Add internal phy support

Hi David, Am Dienstag, 27. Juni 2017, 22:33:20 CEST schrieb David.Wu: > 在 2017/6/24 1:19, Heiko Stuebner 写道: > > Am Freitag, 23. Juni 2017, 12:59:07 CEST schrieb David Wu: > >> To make internal phy worked, need to configure the phy_clock, > >> phy cru_reset and related registers. > >> > >>

Re: [PATCH 05/11] net: stmmac: dwmac-rk: Add internal phy support

> I'm a little confused for the property of phy-mode = "internal". > If the property of phy-mode is configured as "internal" from DT , i > could not get the rmii or rgmii mode for the phy. > I use it to differentiate rmii or rgmii for different configuration. phy-mode is about the bus between the

Re: [PATCH 05/11] net: stmmac: dwmac-rk: Add internal phy support

Hi Heiko, 在 2017/6/24 1:19, Heiko Stuebner 写道: Hi David, Am Freitag, 23. Juni 2017, 12:59:07 CEST schrieb David Wu: To make internal phy worked, need to configure the phy_clock, phy cru_reset and related registers. Change-Id: I6971c0a769754b824b1b908b56080cbaf7867d13 please remove all

Re: [PATCH 05/11] net: stmmac: dwmac-rk: Add internal phy support

Hi Florian, Sorry for reply late. 在 2017/6/24 0:22, Florian Fainelli 写道: On 06/22/2017 09:59 PM, David Wu wrote: To make internal phy worked, need to configure the phy_clock, phy cru_reset and related registers. Change-Id: I6971c0a769754b824b1b908b56080cbaf7867d13 Signed-off-by: David Wu

Re: [PATCH 05/11] net: stmmac: dwmac-rk: Add internal phy support

On Fri, Jun 23, 2017 at 12:59:07PM +0800, David Wu wrote: > To make internal phy worked, need to configure the phy_clock, > phy cru_reset and related registers. > > Change-Id: I6971c0a769754b824b1b908b56080cbaf7867d13 > Signed-off-by: David Wu > --- >

Re: [PATCH 05/11] net: stmmac: dwmac-rk: Add internal phy support

Hi David, Am Freitag, 23. Juni 2017, 12:59:07 CEST schrieb David Wu: > To make internal phy worked, need to configure the phy_clock, > phy cru_reset and related registers. > > Change-Id: I6971c0a769754b824b1b908b56080cbaf7867d13 please remove all Change-Ids from patches before sending upstream.

Re: [PATCH 05/11] net: stmmac: dwmac-rk: Add internal phy support

On 06/22/2017 09:59 PM, David Wu wrote: > To make internal phy worked, need to configure the phy_clock, > phy cru_reset and related registers. > > Change-Id: I6971c0a769754b824b1b908b56080cbaf7867d13 > Signed-off-by: David Wu > --- >

[PATCH 05/11] net: stmmac: dwmac-rk: Add internal phy support

To make internal phy worked, need to configure the phy_clock, phy cru_reset and related registers. Change-Id: I6971c0a769754b824b1b908b56080cbaf7867d13 Signed-off-by: David Wu --- .../devicetree/bindings/net/rockchip-dwmac.txt | 3 +