Re: [PATCH 05/14] net: sched: always take reference to action

2018-05-15 Thread Vlad Buslov
On Tue 15 May 2018 at 08:58, Jiri Pirko wrote: > Mon, May 14, 2018 at 08:49:07PM CEST, vla...@mellanox.com wrote: >> >>On Mon 14 May 2018 at 16:23, Jiri Pirko wrote: >>> Mon, May 14, 2018 at 04:27:06PM CEST, vla...@mellanox.com wrote: Without rtnl lock

Re: [PATCH 05/14] net: sched: always take reference to action

2018-05-15 Thread Jiri Pirko
Mon, May 14, 2018 at 08:49:07PM CEST, vla...@mellanox.com wrote: > >On Mon 14 May 2018 at 16:23, Jiri Pirko wrote: >> Mon, May 14, 2018 at 04:27:06PM CEST, vla...@mellanox.com wrote: >>>Without rtnl lock protection it is no longer safe to use pointer to tc >>>action without

Re: [PATCH 05/14] net: sched: always take reference to action

2018-05-14 Thread kbuild test robot
Hi Vlad, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net/master] [also build test WARNING on v4.17-rc5 next-20180514] [cannot apply to net-next/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 05/14] net: sched: always take reference to action

2018-05-14 Thread Vlad Buslov
On Mon 14 May 2018 at 16:23, Jiri Pirko wrote: > Mon, May 14, 2018 at 04:27:06PM CEST, vla...@mellanox.com wrote: >>Without rtnl lock protection it is no longer safe to use pointer to tc >>action without holding reference to it. (it can be destroyed concurrently) >> >>Remove

Re: [PATCH 05/14] net: sched: always take reference to action

2018-05-14 Thread Jiri Pirko
Mon, May 14, 2018 at 04:27:06PM CEST, vla...@mellanox.com wrote: >Without rtnl lock protection it is no longer safe to use pointer to tc >action without holding reference to it. (it can be destroyed concurrently) > >Remove unsafe action idr lookup function. Instead of it, implement safe tcf >idr

[PATCH 05/14] net: sched: always take reference to action

2018-05-14 Thread Vlad Buslov
Without rtnl lock protection it is no longer safe to use pointer to tc action without holding reference to it. (it can be destroyed concurrently) Remove unsafe action idr lookup function. Instead of it, implement safe tcf idr check function that atomically looks up action in idr and increments