Re: [PATCH 08/15] net: wireless: simplify return flow for usb_control_msg

2015-10-21 Thread punit vara
On Wed, Oct 21, 2015 at 8:30 PM, Jiri Slaby wrote: > On 10/21/2015, 04:55 PM, Punit Vara wrote: >> @@ -544,13 +544,10 @@ static void at76_ledtrig_tx_activity(void) >> static int at76_remap(struct usb_device *udev) >> { >> int ret; >> - ret = usb_control_msg(udev, usb_sndctrlpipe(udev,

[PATCH 08/15] net: wireless: simplify return flow for usb_control_msg

2015-10-21 Thread Punit Vara
This patch is to the at76c50x-usb.c file that fixes up warning reported by coccicheck: WARNING: end returns can be simplified if negative or 0 value Prefer direct return value instead of writing 2-3 more sentence. Signed-off-by: Punit Vara --- drivers/net/wireless/at76c50x-usb.c | 5 + 1 f

Re: [PATCH 08/15] net: wireless: simplify return flow for usb_control_msg

2015-10-21 Thread Jiri Slaby
On 10/21/2015, 04:55 PM, Punit Vara wrote: > @@ -544,13 +544,10 @@ static void at76_ledtrig_tx_activity(void) > static int at76_remap(struct usb_device *udev) > { > int ret; > - ret = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), 0x0a, > + return usb_control_msg(udev, usb_sndctrlp