Re: [PATCH 09/14] net: tcp_memcontrol: simplify linkage between socket and page counter

2015-11-24 Thread Vladimir Davydov
On Mon, Nov 23, 2015 at 01:20:37PM -0500, Johannes Weiner wrote: > On Mon, Nov 23, 2015 at 12:36:46PM +0300, Vladimir Davydov wrote: > > On Fri, Nov 20, 2015 at 01:56:48PM -0500, Johannes Weiner wrote: > > > I actually had all this at first, but then wondered if it makes more > > > sense to keep th

Re: [PATCH 09/14] net: tcp_memcontrol: simplify linkage between socket and page counter

2015-11-23 Thread Johannes Weiner
On Mon, Nov 23, 2015 at 12:36:46PM +0300, Vladimir Davydov wrote: > On Fri, Nov 20, 2015 at 01:56:48PM -0500, Johannes Weiner wrote: > > I actually had all this at first, but then wondered if it makes more > > sense to keep the legacy code in isolation. Don't you think it would > > be easier to kee

Re: [PATCH 09/14] net: tcp_memcontrol: simplify linkage between socket and page counter

2015-11-23 Thread Vladimir Davydov
On Fri, Nov 20, 2015 at 01:56:48PM -0500, Johannes Weiner wrote: > On Fri, Nov 20, 2015 at 03:42:16PM +0300, Vladimir Davydov wrote: > > On Thu, Nov 12, 2015 at 06:41:28PM -0500, Johannes Weiner wrote: > > > There won't be any separate counters for socket memory consumed by > > > protocols other th

Re: [PATCH 09/14] net: tcp_memcontrol: simplify linkage between socket and page counter

2015-11-20 Thread Johannes Weiner
On Fri, Nov 20, 2015 at 03:42:16PM +0300, Vladimir Davydov wrote: > On Thu, Nov 12, 2015 at 06:41:28PM -0500, Johannes Weiner wrote: > > There won't be any separate counters for socket memory consumed by > > protocols other than TCP in the future. Remove the indirection and > > I really want to be

Re: [PATCH 09/14] net: tcp_memcontrol: simplify linkage between socket and page counter

2015-11-20 Thread Vladimir Davydov
On Thu, Nov 12, 2015 at 06:41:28PM -0500, Johannes Weiner wrote: > There won't be any separate counters for socket memory consumed by > protocols other than TCP in the future. Remove the indirection and I really want to believe you're right. And with vmpressure propagation implemented properly you

[PATCH 09/14] net: tcp_memcontrol: simplify linkage between socket and page counter

2015-11-12 Thread Johannes Weiner
There won't be any separate counters for socket memory consumed by protocols other than TCP in the future. Remove the indirection and link sockets directly to their owning memory cgroup. Signed-off-by: Johannes Weiner --- include/linux/memcontrol.h | 18 +++- include/net/sock.h