Re: [PATCH 1/1][SUNDANCE]: support ENL832-TX-ICNT ENCORE card

2005-12-19 Thread Randy.Dunlap
On Mon, 19 Dec 2005, Arnaldo Carvalho de Melo wrote: > > Many years ago, when I worked on network drivers, (iirc) > > PHY 0 was to be used only if no other PHYs were present, > > so it should be checked last, not first. > > Hey, I should start the Janitor's Driver Development Documentation > Proje

Re: [PATCH 1/1][SUNDANCE]: support ENL832-TX-ICNT ENCORE card

2005-12-19 Thread John W. Linville
On Mon, Dec 19, 2005 at 09:07:52AM -0800, Randy.Dunlap wrote: > On Mon, 19 Dec 2005, John W. Linville wrote: > > > Hmmm...that seems odd. Of course, that is the way I had it before > > Jeff told me to change it to probe PHY ID 0 last... :-) > > Many years ago, when I worked on network drivers, (

Re: [PATCH 1/1][SUNDANCE]: support ENL832-TX-ICNT ENCORE card

2005-12-19 Thread Arnaldo Carvalho de Melo
On 12/19/05, Randy.Dunlap <[EMAIL PROTECTED]> wrote: > On Mon, 19 Dec 2005, John W. Linville wrote: > > > On Mon, Dec 19, 2005 at 04:43:51PM +0100, Lennert Buytenhek wrote: > > > On Mon, Dec 19, 2005 at 10:09:32AM -0500, John W. Linville wrote: > > > > > > > > > @@ -633,7 +643,7 @@ static int __dev

Re: [PATCH 1/1][SUNDANCE]: support ENL832-TX-ICNT ENCORE card

2005-12-19 Thread Randy.Dunlap
On Mon, 19 Dec 2005, John W. Linville wrote: > On Mon, Dec 19, 2005 at 04:43:51PM +0100, Lennert Buytenhek wrote: > > On Mon, Dec 19, 2005 at 10:09:32AM -0500, John W. Linville wrote: > > > > > > > @@ -633,7 +643,7 @@ static int __devinit sundance_probe1 (st > > > > > > > > > > np->phys[0] =

[PATCH 1/1][SUNDANCE]: support ENL832-TX-ICNT ENCORE card

2005-12-19 Thread Arnaldo Carvalho de Melo
On 12/19/05, Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> wrote: > On 12/19/05, John W. Linville <[EMAIL PROTECTED]> wrote: > > On Mon, Dec 19, 2005 at 03:35:04PM +0100, Lennert Buytenhek wrote: > > > On Mon, Dec 19, 2005 at 12:20:32PM -0200, Arnaldo Carvalho de Melo wrote: > > > > > > > @@ -633,7

Re: [PATCH 1/1][SUNDANCE]: support ENL832-TX-ICNT ENCORE card

2005-12-19 Thread John W. Linville
On Mon, Dec 19, 2005 at 02:08:58PM -0200, Arnaldo Carvalho de Melo wrote: > On 12/19/05, John W. Linville <[EMAIL PROTECTED]> wrote: > > On Mon, Dec 19, 2005 at 03:35:04PM +0100, Lennert Buytenhek wrote: > > > On Mon, Dec 19, 2005 at 12:20:32PM -0200, Arnaldo Carvalho de Melo wrote: > > > > > > > @

Re: [PATCH 1/1][SUNDANCE]: support ENL832-TX-ICNT ENCORE card

2005-12-19 Thread Arnaldo Carvalho de Melo
On 12/19/05, John W. Linville <[EMAIL PROTECTED]> wrote: > On Mon, Dec 19, 2005 at 03:35:04PM +0100, Lennert Buytenhek wrote: > > On Mon, Dec 19, 2005 at 12:20:32PM -0200, Arnaldo Carvalho de Melo wrote: > > > > > @@ -633,7 +643,7 @@ static int __devinit sundance_probe1 (st > > > > > > np->phys

Re: [PATCH 1/1][SUNDANCE]: support ENL832-TX-ICNT ENCORE card

2005-12-19 Thread John W. Linville
On Mon, Dec 19, 2005 at 04:43:51PM +0100, Lennert Buytenhek wrote: > On Mon, Dec 19, 2005 at 10:09:32AM -0500, John W. Linville wrote: > > > > > @@ -633,7 +643,7 @@ static int __devinit sundance_probe1 (st > > > > > > > > np->phys[0] = 1;/* Default setting */ > > > >

Re: [PATCH 1/1][SUNDANCE]: support ENL832-TX-ICNT ENCORE card

2005-12-19 Thread Lennert Buytenhek
On Mon, Dec 19, 2005 at 10:09:32AM -0500, John W. Linville wrote: > > > @@ -633,7 +643,7 @@ static int __devinit sundance_probe1 (st > > > > > > np->phys[0] = 1;/* Default setting */ > > > np->mii_preamble_required++; > > > - for (phy = 1; phy <= 32 && phy_idx < MII_CNT; phy+

Re: [PATCH 1/1][SUNDANCE]: support ENL832-TX-ICNT ENCORE card

2005-12-19 Thread John W. Linville
On Mon, Dec 19, 2005 at 03:35:04PM +0100, Lennert Buytenhek wrote: > On Mon, Dec 19, 2005 at 12:20:32PM -0200, Arnaldo Carvalho de Melo wrote: > > > @@ -633,7 +643,7 @@ static int __devinit sundance_probe1 (st > > > > np->phys[0] = 1;/* Default setting */ > > np->mii_prea

Re: [PATCH 1/1][SUNDANCE]: support ENL832-TX-ICNT ENCORE card

2005-12-19 Thread Lennert Buytenhek
On Mon, Dec 19, 2005 at 12:20:32PM -0200, Arnaldo Carvalho de Melo wrote: > @@ -633,7 +643,7 @@ static int __devinit sundance_probe1 (st > > np->phys[0] = 1;/* Default setting */ > np->mii_preamble_required++; > - for (phy = 1; phy <= 32 && phy_idx < MII_CNT; phy+

[PATCH 1/1][SUNDANCE]: support ENL832-TX-ICNT ENCORE card

2005-12-19 Thread Arnaldo Carvalho de Melo
Hi Jeff, Yesterday I've bought an el-cheapo encore ENL832-TX-ICNT eth card, sundance based, that didn't worked with the in-kernel sundance driver, after some googling I've found this driver: http://www.encore-usa.com/Drivers/ENL832-TX-ICNT_Drivers.zip Merged some bits and got this beast workin