leine-Budde
Cc: w...@grandegger.com; andri.yngva...@marel.com; linux-...@vger.kernel.org;
netdev@vger.kernel.org; linux-kernel; Christian Magnusson
Subject: Re: [PATCH 1/1] can: sja1000: clear interrupts on start
2015-11-11 13:37 GMT+01:00 Marc Kleine-Budde :
>> Some cred should go to Chris
On 11/11/2015 01:46 PM, Mirza Krak wrote:
> 2015-11-11 13:37 GMT+01:00 Marc Kleine-Budde :
>>> Some cred should go to Christian (added him to CC) for finding this
>>> problem and reporting it to me.
>>
>> I'll add a
>>
>> Reported-by: Christian Magnusson
>>
>> to the patch.
>
> Can we just get an
2015-11-11 13:37 GMT+01:00 Marc Kleine-Budde :
>> Some cred should go to Christian (added him to CC) for finding this
>> problem and reporting it to me.
>
> I'll add a
>
> Reported-by: Christian Magnusson
>
> to the patch.
>
Can we just get an ACK that it is OK from Christian before we do it.
On 11/11/2015 01:29 PM, Mirza Krak wrote:
>> Can you put a scope on the interrupt pin and see if it's a problem of
>> the SoC and/or Linux or the SJA1000 not pulling the IRQ line.
>
> A little demonstration on what it looks like when the system is
> resumed (added a printk in sja1000_start without
2015-11-11 11:06 GMT+01:00 Marc Kleine-Budde :
> On 11/11/2015 10:54 AM, Mirza Krak wrote:
>> 2015-11-11 9:04 GMT+01:00 Marc Kleine-Budde :
>>> This problem occurs only an hardware, where the SJA1000 is powered
>>> during system suspend?
>>
>> Correct, and the controller is in UP state.
>>
>>> Does
On 11/11/2015 10:54 AM, Mirza Krak wrote:
> 2015-11-11 9:04 GMT+01:00 Marc Kleine-Budde :
>> This problem occurs only an hardware, where the SJA1000 is powered
>> during system suspend?
>
> Correct, and the controller is in UP state.
>
>> Doesn't the SJA1000 trigger an interrupt that is detected
2015-11-11 9:04 GMT+01:00 Marc Kleine-Budde :
> This problem occurs only an hardware, where the SJA1000 is powered
> during system suspend?
Correct, and the controller is in UP state.
> Doesn't the SJA1000 trigger an interrupt that is detected after
> resuming? You add the fix to the open() func
On 11/10/2015 02:59 PM, Mirza Krak wrote:
> From: Mirza Krak
>
> According to SJA1000 data sheet error-warning (EI) interrupt is not
> cleared by setting the controller in to reset-mode.
>
> Then if we have the following case:
> - system is suspended (echo mem > /sys/power/state) and SJA1000 is
From: Mirza Krak
According to SJA1000 data sheet error-warning (EI) interrupt is not
cleared by setting the controller in to reset-mode.
Then if we have the following case:
- system is suspended (echo mem > /sys/power/state) and SJA1000 is left
in operating state
- A bus error condition occurs w
