Re: [PATCH 1/1] net: bcmgenet: fix incorrect return value checks

2017-04-24 Thread Florian Fainelli
On 04/24/2017 12:48 PM, David Miller wrote: > From: Pan Bian > Date: Sun, 23 Apr 2017 18:01:05 +0800 > >> From: Pan Bian >> >> Function platform_get_irq() will return a negative value on errors. >> However, in function bcmgenet_probe(), 0 is

Re: [PATCH 1/1] net: bcmgenet: fix incorrect return value checks

2017-04-24 Thread David Miller
From: Pan Bian Date: Sun, 23 Apr 2017 18:01:05 +0800 > From: Pan Bian > > Function platform_get_irq() will return a negative value on errors. > However, in function bcmgenet_probe(), 0 is considered as a flag of > error. This patch fixes the bug by

[PATCH 1/1] net: bcmgenet: fix incorrect return value checks

2017-04-23 Thread Pan Bian
From: Pan Bian Function platform_get_irq() will return a negative value on errors. However, in function bcmgenet_probe(), 0 is considered as a flag of error. This patch fixes the bug by checking whether the return value of platform_get_irq() is less than 0. Signed-off-by: