Re: [PATCH 1/2] net: macb: reduce scope of rx_fs_lock-protected regions

2017-12-05 Thread David Miller
From: Julia Cartwright Date: Tue, 5 Dec 2017 14:17:11 -0600 > While Julia Lawall's cocci-generated patch fixes the problem, the right > solution is to obviate the problem altogether. I already applied Julia's patch. And I hope that if you generated this against current net-next you would have s

Re: [PATCH 1/2] net: macb: reduce scope of rx_fs_lock-protected regions

2017-12-05 Thread Nicolas Ferre
On 05/12/2017 at 21:17, Julia Cartwright wrote: > Commit ae8223de3df5 ("net: macb: Added support for RX filtering") > introduces a lock, rx_fs_lock which is intended to protect the list of > rx_flow items and synchronize access to the hardware rx filtering > registers. > > However, the region prot

[PATCH 1/2] net: macb: reduce scope of rx_fs_lock-protected regions

2017-12-05 Thread Julia Cartwright
Commit ae8223de3df5 ("net: macb: Added support for RX filtering") introduces a lock, rx_fs_lock which is intended to protect the list of rx_flow items and synchronize access to the hardware rx filtering registers. However, the region protected by this lock is overscoped, unnecessarily including th