Re: [PATCH 1/2] net: mvneta: remove bogus use of

2017-08-04 Thread Marcin Wojtas
Hi Gregory, >From my side: +1 to your modification. Thanks, Marcin 2017-08-04 17:26 GMT+02:00 Gregory CLEMENT : > Hi Rob, > > On jeu., juil. 20 2017, Rob Herring wrote: > >> On Thu, Jul 20, 2017 at 10:06 AM, Gregory CLEMENT >> wrote: >>> Hi Rob, >>> >>> On jeu., juil. 20 2017, Rob Herring w

Re: [PATCH 1/2] net: mvneta: remove bogus use of

2017-08-04 Thread Gregory CLEMENT
Hi Rob, On jeu., juil. 20 2017, Rob Herring wrote: > On Thu, Jul 20, 2017 at 10:06 AM, Gregory CLEMENT > wrote: >> Hi Rob, >> >> On jeu., juil. 20 2017, Rob Herring wrote: >> >> (Adding Marcin in CC who wrote this part of code) >> >>> Nothing sets ever sets data, so it is always NULL. Remov

Re: [PATCH 1/2] net: mvneta: remove bogus use of device_node.data ptr

2017-07-20 Thread Sergei Shtylyov
Hello! On 07/20/2017 05:27 PM, Rob Herring wrote: Nothing sets ever sets data, so it is always NULL. Remove it as this is "Sets" once is enough. :-) the only user of data ptr in the whole kernel, and it is going to be removed from struct device_node. Cc: Thomas Petazzoni Signed-off-by:

Re: [PATCH 1/2] net: mvneta: remove bogus use of

2017-07-20 Thread Rob Herring
On Thu, Jul 20, 2017 at 10:06 AM, Gregory CLEMENT wrote: > Hi Rob, > > On jeu., juil. 20 2017, Rob Herring wrote: > > (Adding Marcin in CC who wrote this part of code) > >> Nothing sets ever sets data, so it is always NULL. Remove it as this is >> the only user of data ptr in the whole kernel, a

Re: [PATCH 1/2] net: mvneta: remove bogus use of

2017-07-20 Thread Marcin Wojtas
Hi Rob, I somehow missed this patch. 2017-07-20 17:06 GMT+02:00 Gregory CLEMENT : > Hi Rob, > > On jeu., juil. 20 2017, Rob Herring wrote: > > (Adding Marcin in CC who wrote this part of code) > >> Nothing sets ever sets data, so it is always NULL. Remove it as this is >> the only user of data

Re: [PATCH 1/2] net: mvneta: remove bogus use of

2017-07-20 Thread Gregory CLEMENT
Hi Rob, On jeu., juil. 20 2017, Rob Herring wrote: (Adding Marcin in CC who wrote this part of code) > Nothing sets ever sets data, so it is always NULL. Remove it as this is > the only user of data ptr in the whole kernel, and it is going to be > removed from struct device_node. Actually th

[PATCH 1/2] net: mvneta: remove bogus use of device_node.data ptr

2017-07-20 Thread Rob Herring
Nothing sets ever sets data, so it is always NULL. Remove it as this is the only user of data ptr in the whole kernel, and it is going to be removed from struct device_node. Cc: Thomas Petazzoni Signed-off-by: Rob Herring --- Probably there's a better fix here to actually enable the h/w buffer