Re: [PATCH 1/2] qed: Replace memset with eth_zero_addr

2017-01-16 Thread Shyam Saini
On Mon, Jan 16, 2017 at 11:46:06AM -0500, David Miller wrote: > From: Shyam Saini > Date: Mon, 16 Jan 2017 14:54:35 +0530 > > > On Sun, Jan 15, 2017 at 11:38:30PM -0500, David Miller wrote: > >> > >> Please do not ever submit two patches which have the same exact commit

Re: [PATCH 1/2] qed: Replace memset with eth_zero_addr

2017-01-16 Thread David Miller
From: "Mintz, Yuval" Date: Mon, 16 Jan 2017 17:05:05 + > Other than the fact these 2 patches change 2 different qed files, That's what I was trying to hint at, the locations within the drivers were the unique element. > is there any significant difference between

RE: [PATCH 1/2] qed: Replace memset with eth_zero_addr

2017-01-16 Thread Mintz, Yuval
> > On Sun, Jan 15, 2017 at 11:38:30PM -0500, David Miller wrote: > >> > >> Please do not ever submit two patches which have the same exact > >> commit header line, as these two patches do. > >> > >> When someone looks into the shortlog of GIT history all they will see > >> is "qed: Replace memset

Re: [PATCH 1/2] qed: Replace memset with eth_zero_addr

2017-01-16 Thread David Miller
From: Shyam Saini Date: Mon, 16 Jan 2017 14:54:35 +0530 > On Sun, Jan 15, 2017 at 11:38:30PM -0500, David Miller wrote: >> >> Please do not ever submit two patches which have the same exact commit >> header line, as these two patches do. >> >> When someone looks into

Re: [PATCH 1/2] qed: Replace memset with eth_zero_addr

2017-01-16 Thread Shyam Saini
On Sun, Jan 15, 2017 at 11:38:30PM -0500, David Miller wrote: > > Please do not ever submit two patches which have the same exact commit > header line, as these two patches do. > > When someone looks into the shortlog of GIT history all they will see > is "qed: Replace memset with eth_zero_addr"

Re: [PATCH 1/2] qed: Replace memset with eth_zero_addr

2017-01-15 Thread David Miller
Please do not ever submit two patches which have the same exact commit header line, as these two patches do. When someone looks into the shortlog of GIT history all they will see is "qed: Replace memset with eth_zero_addr" twice. This gives the reader no idea what might be different between

[PATCH 1/2] qed: Replace memset with eth_zero_addr

2017-01-15 Thread Shyam Saini
Use eth_zero_addr to assign zero address to the given address array instead of memset when the second argument in memset is address of zero. Also, it makes the code clearer Signed-off-by: Shyam Saini --- drivers/net/ethernet/qlogic/qed/qed_l2.c | 2 +- 1 file changed, 1