Re: [PATCH 1/2] r8169: reinstate ALDPS for power saving

Kai Heng Feng wrote: Hopefully Hayes (or Realtek) can shed more lights on the issue. Apparently ALDPS and ASPM for r8169 is enabled in different commercial products, just not in Linux mainline. Hayes and Realtek folks, How do we make this patch going forward? Do

Re: [PATCH 1/2] r8169: reinstate ALDPS for power saving

> On 15 Nov 2017, at 6:53 PM, David Miller wrote: > > From: Kai-Heng Feng > Date: Wed, 15 Nov 2017 04:00:18 -0500 > >> Commit ("r8169: enable ALDPS for power saving") caused a regression on >> RTL8168evl/8111evl [1], so it got reverted. >>

Re: [PATCH 1/2] r8169: reinstate ALDPS for power saving

David Miller : [...] > The amount of coverage this change is going to get is very small as > well, meaning an even greater chance of regressions. Yes. > Therefore the only acceptable way to handle this is to have > a white-list, specific chips that have been explicitly

Re: [PATCH 1/2] r8169: reinstate ALDPS for power saving

From: Kai-Heng Feng Date: Wed, 15 Nov 2017 04:00:18 -0500 > Commit ("r8169: enable ALDPS for power saving") caused a regression on > RTL8168evl/8111evl [1], so it got reverted. > > Instead of reverting the whole commit, let's reinstate ALDPS for all > models other

[PATCH 1/2] r8169: reinstate ALDPS for power saving

Commit ("r8169: enable ALDPS for power saving") caused a regression on RTL8168evl/8111evl [1], so it got reverted. Instead of reverting the whole commit, let's reinstate ALDPS for all models other than RTL8168evl/8111evl. [1] https://lkml.org/lkml/2013/1/5/36 Cc: Francois Romieu