Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-15 Thread Andrew Morton
On Wed, 13 Feb 2008 14:00:24 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: Hello! This is an updated version of the patch posted last November: http://archives.free.net.ph/message/20071201.003721.cd6ff17c.en.html This new version permits arguments with side effects, for example:

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-15 Thread Paul E. McKenney
On Fri, Feb 15, 2008 at 04:40:24PM -0800, Andrew Morton wrote: On Wed, 13 Feb 2008 14:00:24 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: Hello! This is an updated version of the patch posted last November: http://archives.free.net.ph/message/20071201.003721.cd6ff17c.en.html

[PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Paul E. McKenney
Hello! This is an updated version of the patch posted last November: http://archives.free.net.ph/message/20071201.003721.cd6ff17c.en.html This new version permits arguments with side effects, for example: rcu_assign_pointer(global_p, p++); and also verifies that the arguments

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Andrew Morton
On Wed, 13 Feb 2008 14:00:24 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: Hello! This is an updated version of the patch posted last November: http://archives.free.net.ph/message/20071201.003721.cd6ff17c.en.html This new version permits arguments with side effects, for example:

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Paul E. McKenney
On Wed, Feb 13, 2008 at 02:35:37PM -0800, Stephen Hemminger wrote: On Wed, 13 Feb 2008 14:00:24 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: Hello! This is an updated version of the patch posted last November:

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Paul E. McKenney
On Wed, Feb 13, 2008 at 02:42:33PM -0800, Stephen Hemminger wrote: On Wed, 13 Feb 2008 14:41:34 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: On Wed, Feb 13, 2008 at 02:35:37PM -0800, Stephen Hemminger wrote: On Wed, 13 Feb 2008 14:00:24 -0800 Paul E. McKenney [EMAIL PROTECTED]

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread David Miller
From: Andrew Morton [EMAIL PROTECTED] Date: Wed, 13 Feb 2008 15:52:45 -0800 On Wed, 13 Feb 2008 15:37:44 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: Ah. It does take a bit to get fib_trie into one's build -- allyesconfig doesn't cut it. This is not good. The sole purpose of

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Andrew Morton
On Wed, 13 Feb 2008 15:37:44 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: Ah. It does take a bit to get fib_trie into one's build -- allyesconfig doesn't cut it. This is not good. The sole purpose of allmodconfig and allyesconfig is for compilation and linkage coverage testing. Hence we

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Stephen Hemminger
On Wed, 13 Feb 2008 15:37:44 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: On Wed, Feb 13, 2008 at 02:42:33PM -0800, Stephen Hemminger wrote: On Wed, 13 Feb 2008 14:41:34 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: On Wed, Feb 13, 2008 at 02:35:37PM -0800, Stephen Hemminger

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Stephen Hemminger
On Wed, 13 Feb 2008 15:52:45 -0800 Andrew Morton [EMAIL PROTECTED] wrote: On Wed, 13 Feb 2008 15:37:44 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: Ah. It does take a bit to get fib_trie into one's build -- allyesconfig doesn't cut it. This is not good. The sole purpose of

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Andrew Morton
On Wed, 13 Feb 2008 15:57:38 -0800 (PST) David Miller [EMAIL PROTECTED] wrote: From: Andrew Morton [EMAIL PROTECTED] Date: Wed, 13 Feb 2008 15:52:45 -0800 On Wed, 13 Feb 2008 15:37:44 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: Ah. It does take a bit to get fib_trie into one's

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Paul E. McKenney
On Wed, Feb 13, 2008 at 03:51:58PM -0800, Stephen Hemminger wrote: On Wed, 13 Feb 2008 15:37:44 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: On Wed, Feb 13, 2008 at 02:42:33PM -0800, Stephen Hemminger wrote: On Wed, 13 Feb 2008 14:41:34 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote:

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Stephen Hemminger
On Wed, 13 Feb 2008 16:14:04 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: On Wed, Feb 13, 2008 at 03:51:58PM -0800, Stephen Hemminger wrote: On Wed, 13 Feb 2008 15:37:44 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: On Wed, Feb 13, 2008 at 02:42:33PM -0800, Stephen Hemminger wrote:

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Paul E. McKenney
On Wed, Feb 13, 2008 at 04:27:00PM -0800, Stephen Hemminger wrote: On Wed, 13 Feb 2008 16:14:04 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: On Wed, Feb 13, 2008 at 03:51:58PM -0800, Stephen Hemminger wrote: [ . . . ] Maybe cast both sides to void * in this case: static inline

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Stephen Hemminger
On Wed, 13 Feb 2008 16:42:53 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: On Wed, Feb 13, 2008 at 04:27:00PM -0800, Stephen Hemminger wrote: On Wed, 13 Feb 2008 16:14:04 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: On Wed, Feb 13, 2008 at 03:51:58PM -0800, Stephen Hemminger wrote:

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Paul E. McKenney
On Wed, Feb 13, 2008 at 04:53:56PM -0800, Stephen Hemminger wrote: On Wed, 13 Feb 2008 16:42:53 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: On Wed, Feb 13, 2008 at 04:27:00PM -0800, Stephen Hemminger wrote: [ . . . ] That is heading towards ugly... Maybe not using the macro at all

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Stephen Hemminger
On Wed, 13 Feb 2008 17:34:27 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: On Wed, Feb 13, 2008 at 04:53:56PM -0800, Stephen Hemminger wrote: On Wed, 13 Feb 2008 16:42:53 -0800 Paul E. McKenney [EMAIL PROTECTED] wrote: On Wed, Feb 13, 2008 at 04:27:00PM -0800, Stephen Hemminger wrote: