Re: [PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock

2016-12-22 Thread Rob Herring
On Mon, Dec 19, 2016 at 5:23 PM, Geoff Lansberry wrote: > I can make that change, however, I worry that it may be a bit > misleading, since there are only two supported clock frequencies, but > a number like that to me implies that it could be set to any number > you want. I'm

Re: [PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock

2016-12-20 Thread Geoff Lansberry
On Tue, Dec 20, 2016 at 1:11 PM, Mark Greer wrote: > Hi Geoff. > > Please put the version in your subjects when submitting anything but the > initial version of a patch (e.g., [PATCH v2 1/3]). > > Which series do you want reviewed? > > Mark > -- Sorry about the double

Re: [PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock

2016-12-20 Thread Mark Greer
On Tue, Dec 20, 2016 at 01:29:13PM -0500, Geoff Lansberry wrote: > On Tue, Dec 20, 2016 at 1:11 PM, Mark Greer wrote: > > Hi Geoff. > > > > Please put the version in your subjects when submitting anything but the > > initial version of a patch (e.g., [PATCH v2 1/3]). > > >

Re: [PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock

2016-12-20 Thread Mark Greer
Hi Geoff. Please put the version in your subjects when submitting anything but the initial version of a patch (e.g., [PATCH v2 1/3]). Which series do you want reviewed? Mark --

Re: [PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock

2016-12-20 Thread Jones Desougi
On 2016-12-20 17:16, Geoff Lansberry wrote: > From: Geoff Lansberry > > The TRF7970A has configuration options to support hardware designs > which use a 27.12MHz clock. This commit adds a device tree option > 'clock-frequency' to support configuring the this chip for default >

[PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock

2016-12-20 Thread Geoff Lansberry
From: Geoff Lansberry The TRF7970A has configuration options to support hardware designs which use a 27.12MHz clock. This commit adds a device tree option 'clock-frequency' to support configuring the this chip for default 13.56MHz clock or the optional 27.12MHz clock. ---

[PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock

2016-12-20 Thread Geoff Lansberry
From: Geoff Lansberry The TRF7970A has configuration options to support hardware designs which use a 27.12MHz clock. This commit adds a device tree option 'clock-frequency' to support configuring the this chip for default 13.56MHz clock or the optional 27.12MHz clock. ---

Re: [PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock

2016-12-19 Thread Geoff Lansberry
I can make that change, however, I worry that it may be a bit misleading, since there are only two supported clock frequencies, but a number like that to me implies that it could be set to any number you want. I'm new at this, and so I'll go ahead and change it as you request, but I'd like to

Re: [PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock

2016-12-19 Thread Rob Herring
On Thu, Dec 15, 2016 at 05:30:42PM -0500, Geoff Lansberry wrote: > From: Geoff Lansberry > > --- > .../devicetree/bindings/net/nfc/trf7970a.txt | 3 ++ > drivers/nfc/trf7970a.c | 42 > -- > 2 files changed, 34

Re: [PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock

2016-12-15 Thread Mark Greer
Hi Geoff. On Thu, Dec 15, 2016 at 05:30:42PM -0500, Geoff Lansberry wrote: > From: Geoff Lansberry Please add an informative commit description to all of your commits. No matter how trivial this patch may seem to you now, it may not be to others (or to you in a few years). >

[PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock

2016-12-15 Thread Geoff Lansberry
From: Geoff Lansberry --- .../devicetree/bindings/net/nfc/trf7970a.txt | 3 ++ drivers/nfc/trf7970a.c | 42 -- 2 files changed, 34 insertions(+), 11 deletions(-) diff --git