From: Tobin C Harding
checkpatch produces various white space 'checks'.
This patch amends them.
Signed-off-by: Tobin C Harding
---
This is my second linux kernel patch. Unsure if I was meant to cc multiple
mailing lists?
thanks
net/bridge/netfilter/ebt_stp.c | 24
Hi,
On Tue, May 10, 2016 at 11:26:56AM +1000, tcharding wrote:
> From: Tobin C Harding
>
> checkpatch produces various white space 'checks'.
>
> This patch amends them.
>
> Signed-off-by: Tobin C Harding
> ---
> This is my second linux kernel patch. Unsure if I was meant to cc multiple
> mai
On Tue, 2016-06-07 at 17:14 +0200, Pablo Neira Ayuso wrote:
> On Tue, May 10, 2016 at 11:26:56AM +1000, tcharding wrote:
> > From: Tobin C Harding
> > This is my second linux kernel patch. Unsure if I was meant to cc multiple
> > mailing lists?
[]
> > diff --git a/net/bridge/netfilter/ebt_stp.c b
On Tue, Jun 07, 2016 at 10:04:40AM -0700, Joe Perches wrote:
> On Tue, 2016-06-07 at 17:14 +0200, Pablo Neira Ayuso wrote:
> > On Tue, May 10, 2016 at 11:26:56AM +1000, tcharding wrote:
> > > From: Tobin C Harding
> > > This is my second linux kernel patch. Unsure if I was meant to cc
> > > multi
On Tue, 2016-06-07 at 19:34 +0200, Pablo Neira Ayuso wrote:
> On Tue, Jun 07, 2016 at 10:04:40AM -0700, Joe Perches wrote:
> > One more question, is this chunk below correct from
> > coding style point of view?
>
> if (info->bitmask & EBT_STP_ROOTADDR) {
> verdict = 0;
>
On Tue, Jun 07, 2016 at 11:02:30AM -0700, Joe Perches wrote:
> On Tue, 2016-06-07 at 19:34 +0200, Pablo Neira Ayuso wrote:
> > On Tue, Jun 07, 2016 at 10:04:40AM -0700, Joe Perches wrote:
> > > One more question, is this chunk below correct from
> > > coding style point of view?
> >
> > if
On Wed, 2016-06-08 at 13:52 +0200, Pablo Neira Ayuso wrote:
> On Tue, Jun 07, 2016 at 11:02:30AM -0700, Joe Perches wrote:
> > On Tue, 2016-06-07 at 19:34 +0200, Pablo Neira Ayuso wrote:
> > > On Tue, Jun 07, 2016 at 10:04:40AM -0700, Joe Perches wrote:
> > > > One more question, is this chunk belo
On Wed, Jun 08, 2016 at 09:52:30AM -0700, Joe Perches wrote:
> On Wed, 2016-06-08 at 13:52 +0200, Pablo Neira Ayuso wrote:
> > On Tue, Jun 07, 2016 at 11:02:30AM -0700, Joe Perches wrote:
> > > On Tue, 2016-06-07 at 19:34 +0200, Pablo Neira Ayuso wrote:
> > > > On Tue, Jun 07, 2016 at 10:04:40AM -0
On Wed, Jun 08, 2016 at 07:31:21PM +0200, Pablo Neira Ayuso wrote:
> Then you can follow up with a patch to add this function.
>
> Just a suggestion, let me know if this is fine with you.
Forget this idea.
Actually your patch from: Date: Tue, 07 Jun 2016 11:02:30 -0700
looks easier to readable
On Wed, 2016-06-08 at 19:38 +0200, Pablo Neira Ayuso wrote:
> On Wed, Jun 08, 2016 at 07:31:21PM +0200, Pablo Neira Ayuso wrote:
> > Then you can follow up with a patch to add this function.
> >
> > Just a suggestion, let me know if this is fine with you.
> Forget this idea.
>
> Actually your pat
On Thu, Jun 09, 2016 at 11:00:18AM -0700, Joe Perches wrote:
> On Wed, 2016-06-08 at 19:38 +0200, Pablo Neira Ayuso wrote:
> > On Wed, Jun 08, 2016 at 07:31:21PM +0200, Pablo Neira Ayuso wrote:
> > looks easier to readable than original Tobin's, so I'll wait for you
> > to resubmit.
>
> Well, mayb
11 matches
Mail list logo
