Re: [PATCH 1/3] net: socionext: Stop PHY before resetting netsec

2018-10-18 Thread Masahisa Kojima
Hi, Thank you very much for your comment. I have not realized that reading MII_PHYSID1/ID2 are ignored if the PHY is in power down, this patch has a side effect in ACPI case. My intention is that netsec_reset_hardware() should be called in PHY power down state, but current place to add PHY power

Re: [PATCH 1/3] net: socionext: Stop PHY before resetting netsec

2018-10-18 Thread Florian Fainelli
On 10/18/2018 6:08 PM, masahisa.koj...@linaro.org wrote: > From: Masahisa Kojima > > After resetting netsec IP, driver have to wait until > netsec mode turns to NRM mode. > But sometimes mode transition to NRM will not complete > if the PHY is in normal operation state. > To avoid this situati

[PATCH 1/3] net: socionext: Stop PHY before resetting netsec

2018-10-18 Thread masahisa . kojima
From: Masahisa Kojima After resetting netsec IP, driver have to wait until netsec mode turns to NRM mode. But sometimes mode transition to NRM will not complete if the PHY is in normal operation state. To avoid this situation, stop PHY before resetting netsec. Signed-off-by: Masahisa Kojima Sig