Re: [PATCH 1/4] net: thunderx: Fix IOMMU translation faults

2017-03-07 Thread Sunil Kovvuri
On Mon, Mar 6, 2017 at 10:02 PM, Robin Murphy wrote: > On 06/03/17 12:57, Sunil Kovvuri wrote: We are seeing a 0.75Mpps drop with IP forwarding rate due to that. Hence I have restricted calling DMA interfaces to only when IOMMU is enabled. >>> >>> What's 0.07Mpps as a percenta

Re: [PATCH 1/4] net: thunderx: Fix IOMMU translation faults

2017-03-06 Thread Robin Murphy
On 06/03/17 12:57, Sunil Kovvuri wrote: >>> >>> We are seeing a 0.75Mpps drop with IP forwarding rate due to that. >>> Hence I have restricted calling DMA interfaces to only when IOMMU is >>> enabled. >> >> What's 0.07Mpps as a percentage of baseline? On a correctly configured >> coherent arm64 sy

Re: [PATCH 1/4] net: thunderx: Fix IOMMU translation faults

2017-03-06 Thread Sunil Kovvuri
>> >> We are seeing a 0.75Mpps drop with IP forwarding rate due to that. >> Hence I have restricted calling DMA interfaces to only when IOMMU is enabled. > > What's 0.07Mpps as a percentage of baseline? On a correctly configured > coherent arm64 system, in the absence of an IOMMU, dma_map_*() is >

Re: [PATCH 1/4] net: thunderx: Fix IOMMU translation faults

2017-03-06 Thread Robin Murphy
On 04/03/17 05:54, Sunil Kovvuri wrote: > On Fri, Mar 3, 2017 at 11:26 PM, David Miller wrote: >> From: sunil.kovv...@gmail.com >> Date: Fri, 3 Mar 2017 16:17:47 +0530 >> >>> @@ -1643,6 +1650,9 @@ static int nicvf_probe(struct pci_dev *pdev, const >>> struct pci_device_id *ent) >>> if (!pa

Re: [PATCH 1/4] net: thunderx: Fix IOMMU translation faults

2017-03-03 Thread Sunil Kovvuri
On Fri, Mar 3, 2017 at 11:26 PM, David Miller wrote: > From: sunil.kovv...@gmail.com > Date: Fri, 3 Mar 2017 16:17:47 +0530 > >> @@ -1643,6 +1650,9 @@ static int nicvf_probe(struct pci_dev *pdev, const >> struct pci_device_id *ent) >> if (!pass1_silicon(nic->pdev)) >> nic->hw

Re: [PATCH 1/4] net: thunderx: Fix IOMMU translation faults

2017-03-03 Thread David Miller
From: sunil.kovv...@gmail.com Date: Fri, 3 Mar 2017 16:17:47 +0530 > @@ -1643,6 +1650,9 @@ static int nicvf_probe(struct pci_dev *pdev, const > struct pci_device_id *ent) > if (!pass1_silicon(nic->pdev)) > nic->hw_tso = true; > > + /* Check if we are attached to IOMMU *

[PATCH 1/4] net: thunderx: Fix IOMMU translation faults

2017-03-03 Thread sunil . kovvuri
From: Sunil Goutham ACPI support has been added to ARM IOMMU driver in 4.10 kernel and that has resulted in VNIC interfaces throwing translation faults when kernel is booted with ACPI as driver was not using DMA API. On T88 HW takes care of data coherency when performing DMA operations hence in