Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals

2007/8/30, John W. Linville <[EMAIL PROTECTED]>: > On Thu, Aug 30, 2007 at 04:50:01AM +0300, Nick Kossifidis wrote: > > 2007/8/28, Christoph Hellwig <[EMAIL PROTECTED]>: > > > > ath5k_hw_phy.o should probably be ath5k_phy.o by conventions used by > > > most drivers and ath5k_hw_inivals.o mights asw

Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals

On Thu, Aug 30, 2007 at 04:50:01AM +0300, Nick Kossifidis wrote: > 2007/8/28, Christoph Hellwig <[EMAIL PROTECTED]>: > > ath5k_hw_phy.o should probably be ath5k_phy.o by conventions used by > > most drivers and ath5k_hw_inivals.o mights aswell be something like > > ath5k_init.o > If you check out

Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals

2007/8/28, Christoph Hellwig <[EMAIL PROTECTED]>: > On Tue, Aug 28, 2007 at 11:58:52AM -0400, Jiri Slaby wrote: > > -ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o > > +ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o \ > > + ath5k_hw_phy.o ath5k_hw

Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals

On 8/28/07, Larry Finger <[EMAIL PROTECTED]> wrote: > Johannes Berg wrote: > > On Tue, 2007-08-28 at 18:10 +0100, Christoph Hellwig wrote: > >> On Tue, Aug 28, 2007 at 11:58:52AM -0400, Jiri Slaby wrote: > >>> -ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o > >>> +ath5k-objs =

Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals

Johannes Berg wrote: On Tue, 2007-08-28 at 18:10 +0100, Christoph Hellwig wrote: On Tue, Aug 28, 2007 at 11:58:52AM -0400, Jiri Slaby wrote: -ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o +ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o \ +

Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals

On Tue, 2007-08-28 at 18:10 +0100, Christoph Hellwig wrote: > On Tue, Aug 28, 2007 at 11:58:52AM -0400, Jiri Slaby wrote: > > -ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o > > +ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o \ > > + ath5k_hw_phy.o ath5

Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals

On Tue, Aug 28, 2007 at 11:58:52AM -0400, Jiri Slaby wrote: > -ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o > +ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o \ > + ath5k_hw_phy.o ath5k_hw_inivals.o And while I'm at nitpicking :) ath5k_hw_phy.o

Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals

On Tue, Aug 28, 2007 at 11:58:52AM -0400, Jiri Slaby wrote: > obj-$(CONFIG_ATH5K) += ath5k.o > -ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o > +ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o \ > + ath5k_hw_phy.o ath5k_hw_inivals.o Btw, this s

Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals

On Tue, 2007-08-28 at 11:58 -0400, Jiri Slaby wrote: [...] There really is no need to CC netdev, those on linux-wireless don't need to get it twice (if they're also on netdev) and those on netdev aren't too concerned about wireless-dev (and if they are really need to sign up to linux-wireless) j