Re: [PATCH 1/8] ibm_newemac: Fix possible lockup on close

2007-11-21 Thread Benjamin Herrenschmidt
On Wed, 2007-11-21 at 16:41 +0100, Christoph Hellwig wrote: > On Wed, Nov 21, 2007 at 05:06:39PM +1100, Benjamin Herrenschmidt wrote: > > It's a bad idea to call flush_scheduled_work from within a > > netdev->stop because the linkwatch will occasionally take the > > rtnl lock from a workqueue cont

Re: [PATCH 1/8] ibm_newemac: Fix possible lockup on close

2007-11-21 Thread Josh Boyer
On Wed, 21 Nov 2007 16:41:23 +0100 Christoph Hellwig <[EMAIL PROTECTED]> wrote: > On Wed, Nov 21, 2007 at 05:06:39PM +1100, Benjamin Herrenschmidt wrote: > > It's a bad idea to call flush_scheduled_work from within a > > netdev->stop because the linkwatch will occasionally take the > > rtnl lock f

Re: [PATCH 1/8] ibm_newemac: Fix possible lockup on close

2007-11-21 Thread Christoph Hellwig
On Wed, Nov 21, 2007 at 05:06:39PM +1100, Benjamin Herrenschmidt wrote: > It's a bad idea to call flush_scheduled_work from within a > netdev->stop because the linkwatch will occasionally take the > rtnl lock from a workqueue context, and thus that can deadlock. > > This reworks things a bit in th

[PATCH 1/8] ibm_newemac: Fix possible lockup on close

2007-11-20 Thread Benjamin Herrenschmidt
It's a bad idea to call flush_scheduled_work from within a netdev->stop because the linkwatch will occasionally take the rtnl lock from a workqueue context, and thus that can deadlock. This reworks things a bit in that area to avoid the problem. Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTE