Re: [PATCH 1.3/9] NetXen 1G/10G driver

2006-04-02 Thread Andi Kleen
On Saturday 01 April 2006 15:50, Linsys Contractor Amit S. Kale wrote: Not a full review, just what I noticed from a quick read. > +static int > +netxen_loopback_test(struct net_device *netdev, int fint, void *ptr) [... lots of self test code snipped ...] Isn't that a bit too much self test inf

[PATCH 1.3/9] NetXen 1G/10G driver

2006-04-01 Thread Linsys Contractor Amit S. Kale
+static int +netxen_loopback_test(struct net_device *netdev, int fint, void *ptr) +{ + int ii, ret; + unsigned char *data; + netxen_send_test_t args; + + if ((ret = copy_from_user(&args, ptr, sizeof(a