Re: [PATCH 10/10] chelesio: transmit locking (plus bug fix).

2006-12-04 Thread Stephen Hemminger
On Sun, 3 Dec 2006 11:45:09 +0100 "Eric Lemoine" <[EMAIL PROTECTED]> wrote: > Stephen, > > On 12/2/06, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > > If transmit lock is contended on, then push return code back > > and retry at higher level. > > Looking at qdisc_restart, it seems to me that th

Re: [PATCH 10/10] chelesio: transmit locking (plus bug fix).

2006-12-03 Thread Eric Lemoine
Stephen, On 12/2/06, Stephen Hemminger <[EMAIL PROTECTED]> wrote: If transmit lock is contended on, then push return code back and retry at higher level. Looking at qdisc_restart, it seems to me that the NETDEV_TX_LOCKED return code must only be used if the device features LLTX. With your patc

[PATCH 10/10] chelesio: transmit locking (plus bug fix).

2006-12-01 Thread Stephen Hemminger
If transmit lock is contended on, then push return code back and retry at higher level. Bugfix: If buffer is reallocated because of lack of headroom and the send is blocked, then drop packet. This is necessary because caller would end up requeuing a freed skb. Signed-off-by: Stephen Hemminger <[E