Re: [PATCH 13/24] [IPSEC]: Move x->outer_mode->output out of locked section

2007-11-13 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Tue, 13 Nov 2007 19:51:19 +0800 > On Tue, Nov 13, 2007 at 03:33:48AM -0800, David Miller wrote: > > > > Make 'lastused' an 'unsigned long' (that's all that get_seconds() > > gives to us anyways), fix up the nla_total_size(x->lastused) thing in > > net/xfr

Re: [PATCH 13/24] [IPSEC]: Move x->outer_mode->output out of locked section

2007-11-13 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 07 Nov 2007 22:08:29 +0800 > [IPSEC]: Move x->outer_mode->output out of locked section > > RO mode is the only one that requires a locked output function. So it's > easier to move the lock into that function rather than requiring everyone > else to

Re: [PATCH 13/24] [IPSEC]: Move x->outer_mode->output out of locked section

2007-11-13 Thread Herbert Xu
On Tue, Nov 13, 2007 at 03:33:48AM -0800, David Miller wrote: > > Make 'lastused' an 'unsigned long' (that's all that get_seconds() > gives to us anyways), fix up the nla_total_size(x->lastused) thing in > net/xfrm/xfrm_user.c, and then you can remove this lock acquisition > completely because the

Re: [PATCH 13/24] [IPSEC]: Move x->outer_mode->output out of locked section

2007-11-13 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Thu, 8 Nov 2007 08:39:03 +0800 > On Wed, Nov 07, 2007 at 05:17:42PM +0100, Ingo Oeser wrote: > > Hi Herbert, > > > > Herbert Xu schrieb: > > > diff --git a/net/ipv6/xfrm6_mode_ro.c b/net/ipv6/xfrm6_mode_ro.c > > > index a7bc8c6..4a01cb3 100644 > > > ---

Re: [PATCH 13/24] [IPSEC]: Move x->outer_mode->output out of locked section

2007-11-07 Thread Herbert Xu
On Wed, Nov 07, 2007 at 05:17:42PM +0100, Ingo Oeser wrote: > Hi Herbert, > > Herbert Xu schrieb: > > diff --git a/net/ipv6/xfrm6_mode_ro.c b/net/ipv6/xfrm6_mode_ro.c > > index a7bc8c6..4a01cb3 100644 > > --- a/net/ipv6/xfrm6_mode_ro.c > > +++ b/net/ipv6/xfrm6_mode_ro.c > > @@ -53,7 +54,9 @@ stati

Re: [PATCH 13/24] [IPSEC]: Move x->outer_mode->output out of locked section

2007-11-07 Thread Ingo Oeser
Hi Herbert, Herbert Xu schrieb: > diff --git a/net/ipv6/xfrm6_mode_ro.c b/net/ipv6/xfrm6_mode_ro.c > index a7bc8c6..4a01cb3 100644 > --- a/net/ipv6/xfrm6_mode_ro.c > +++ b/net/ipv6/xfrm6_mode_ro.c > @@ -53,7 +54,9 @@ static int xfrm6_ro_output(struct xfrm_state *x, struct > sk_buff *skb) >

[PATCH 13/24] [IPSEC]: Move x->outer_mode->output out of locked section

2007-11-07 Thread Herbert Xu
[IPSEC]: Move x->outer_mode->output out of locked section RO mode is the only one that requires a locked output function. So it's easier to move the lock into that function rather than requiring everyone else to run under the lock. In particular, this allows us to move the size check into the ou