Re: [PATCH 16/22] staging: rtl8723bs: Fix some indenting problems and a potential data overrun

2017-04-09 Thread Bastien Nocera
On Sat, 2017-04-08 at 11:07 -0500, Larry Finger wrote: > +   if (cam_id >= 0 && cam_id < 32) Isn't there a constant we could use instead of hard-coding this?

[PATCH 16/22] staging: rtl8723bs: Fix some indenting problems and a potential data overrun

2017-04-08 Thread Larry Finger
Smatch reports the following: CHECK drivers/staging/rtl8723bs/core/rtw_wlan_util.c drivers/staging/rtl8723bs/core/rtw_wlan_util.c:67 cckrates_included() warn: if statement not indented drivers/staging/rtl8723bs/core/rtw_wlan_util.c:81 cckratesonly_included() warn: if statement not indented