Re: [PATCH 2/2] [TCP]: Include __tcp_reset_fack_counts to non-__ version

2007-12-17 Thread Ilpo Järvinen
On Tue, 11 Dec 2007, Christoph Hellwig wrote: On Tue, Dec 11, 2007 at 01:50:39PM +0200, Ilpo J?rvinen wrote: + BUG_ON((prev != NULL) !tcp_skb_adjacent(sk, prev, skb[queue])); + + tcp_for_write_queue_from(skb[queue], sk, queue) { + if ((prev !=

[PATCH 2/2] [TCP]: Include __tcp_reset_fack_counts to non-__ version

2007-12-11 Thread Ilpo Järvinen
This makes flow more obvious in case of short-circuit and removes need for prev double pointer fc recount per queue switch. Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] --- include/net/tcp.h | 54 ++-- 1 files changed, 19 insertions(+), 35

Re: [PATCH 2/2] [TCP]: Include __tcp_reset_fack_counts to non-__ version

2007-12-11 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Tue, 11 Dec 2007 13:50:39 +0200 This makes flow more obvious in case of short-circuit and removes need for prev double pointer fc recount per queue switch. Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] Looks good. References to pointers are

Re: [PATCH 2/2] [TCP]: Include __tcp_reset_fack_counts to non-__ version

2007-12-11 Thread Christoph Hellwig
On Tue, Dec 11, 2007 at 01:50:39PM +0200, Ilpo J?rvinen wrote: + BUG_ON((prev != NULL) !tcp_skb_adjacent(sk, prev, skb[queue])); + + tcp_for_write_queue_from(skb[queue], sk, queue) { + if ((prev != NULL) !tcp_skb_adjacent(sk, prev, skb[queue]))