From: Christoph Hellwig [EMAIL PROTECTED]
Date: Fri, 7 Jul 2006 11:09:57 +0200
dev_alloc_skb is designated for RX descriptors, not TX. (Some drivers
use it for the latter anyway, but that's a different story)
Signed-off-by: Christoph Hellwig [EMAIL PROTECTED]
Also applied, thanks a lot.
-
In message [EMAIL PROTECTED],David Miller writes:
From: Christoph Hellwig [EMAIL PROTECTED]
Date: Thu, 13 Jul 2006 22:36:16 +0200
- drivers/atm/{idt77252.c, nicstar.c}, drivers/usb/atm/usbatm.c:
These use private skb queues and do odd things. I can't see
any point for using
On Sat, Jul 08, 2006 at 01:37:38PM -0700, David Miller wrote:
My plan is to give dev_alloc_skb a struct netdevice * argument and
introduce a alloc_netdev_node so the driver can tell what node the
device is on. This gives a significant speedup for cell. I already
have this implemented in
On Thu, 13 Jul 2006 22:36:16 +0200 Christoph Hellwig wrote:
...
I gave converting the dev_alloc_skb prototype everywhere a spin and it
doesn't look too bad. There's only a few places that don't have a
netdevice at hand, and all these look bogus:
...
-
From: Christoph Hellwig [EMAIL PROTECTED]
Date: Thu, 13 Jul 2006 22:36:16 +0200
- drivers/atm/{idt77252.c, nicstar.c}, drivers/usb/atm/usbatm.c:
These use private skb queues and do odd things. I can't see
any point for using dev_alloc_skb with it's additional headroom
On Thu, 13 Jul 2006 22:36:16 +0200
Christoph Hellwig [EMAIL PROTECTED] wrote:
On Sat, Jul 08, 2006 at 01:37:38PM -0700, David Miller wrote:
My plan is to give dev_alloc_skb a struct netdevice * argument and
introduce a alloc_netdev_node so the driver can tell what node the
device is on.
What's the new name? For sanity, don't reuse the name dev_alloc_skb.
dev_alloc_skb. It's the by far sanest name for it, while the old
usage without dev argument was misleading.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More
From: Christoph Hellwig [EMAIL PROTECTED]
Date: Thu, 13 Jul 2006 23:29:19 +0200
What's the new name? For sanity, don't reuse the name dev_alloc_skb.
dev_alloc_skb. It's the by far sanest name for it, while the old
usage without dev argument was misleading.
As much as I would like to make
On Thu, Jul 13, 2006 at 10:36:16PM +0200, Christoph Hellwig wrote:
- net/irda/*:
They allocate the skb in protocol code for TX. Should probably
do a normal alloc_skb like all the other protocol code.
Agreed. I will come up with a patch replacing all the useless dev_alloc_skb()
On Fri, Jul 07, 2006 at 04:55:27PM -0700, David Miller wrote:
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 7 Jul 2006 15:52:55 -0700
What is the point of dev_alloc_skb anyway? all it does is add header space.
In stone-age times it actually had specific semantics, but yes today
it
dev_alloc_skb is designated for RX descriptors, not TX. (Some drivers
use it for the latter anyway, but that's a different story)
Signed-off-by: Christoph Hellwig [EMAIL PROTECTED]
Index: linux-2.6/include/linux/skbuff.h
===
---
On Fri, 7 Jul 2006 11:09:57 +0200
Christoph Hellwig [EMAIL PROTECTED] wrote:
dev_alloc_skb is designated for RX descriptors, not TX. (Some drivers
use it for the latter anyway, but that's a different story)
Signed-off-by: Christoph Hellwig [EMAIL PROTECTED]
Index:
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Fri, 7 Jul 2006 15:52:55 -0700
What is the point of dev_alloc_skb anyway? all it does is add header space.
In stone-age times it actually had specific semantics, but yes today
it is just a synonym.
It's going to be hard to get rid of it, every
David Miller [EMAIL PROTECTED] wrote:
What is the point of dev_alloc_skb anyway? all it does is add header space.
In stone-age times it actually had specific semantics, but yes today
it is just a synonym.
Does anyone still need those 16 bytes of header space?
Cheers,
--
Visit Openswan at
14 matches
Mail list logo
