Re: [PATCH 2/2] ipg: redundancy with mii.h

2006-05-20 Thread David Vrabel
Apologies for the (very) late response. 0007-ipg-plug-leaks-in-the-error-path-of-ipg_nic_open.txt broke receive since it was skipping the initialization of the Rx buffers. Patch attached. Did anyone manage to get a response from IC Plus regarding the required Signed-off-by line? David

Re: [PATCH 2/2] ipg: redundancy with mii.h

2006-05-04 Thread David Vrabel
Francois Romieu wrote: ipg: remove forward declarations It makes no sense in a new driver. Signed-off-by: Francois Romieu [EMAIL PROTECTED] Ack. ipg: replace #define with enum Added some underscores to improve readability. Signed-off-by: Francois

Re: [PATCH 2/2] ipg: redundancy with mii.h

2006-05-04 Thread Francois Romieu
Pekka Enberg [EMAIL PROTECTED] : [...] My initial patches are here: http://www.cs.helsinki.fi/u/penberg/linux/ip1000/ Nice. Thanks. I consider your tree the master now. Please let me know when you have recreated the history, so I can clone your tree. Thanks. The new serie is available in

Re: [PATCH 2/2] ipg: redundancy with mii.h

2006-05-04 Thread Francois Romieu
David Vrabel [EMAIL PROTECTED] : [...] ipg: replace #define with enum Added some underscores to improve readability. Signed-off-by: Francois Romieu [EMAIL PROTECTED] Nack. Register names in code should match those used in the documentation (even if they are a bit

Re: [PATCH 2/2] ipg: redundancy with mii.h

2006-05-03 Thread Pekka J Enberg
Hi Francois, On Tue, 2 May 2006, Francois Romieu wrote: Btw the whole serie is available in branch 'netdev-ipg' at: git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git The interim steps may be useful if testing reveals something wrong (especially if it happens in a few weeks/months).

Re: [PATCH 2/2] ipg: redundancy with mii.h

2006-05-03 Thread Francois Romieu
Pekka J Enberg [EMAIL PROTECTED] : [...] maintain the tree, I can send you my patches so you can recreate the full history. The first steps were produced by quilt on the original out-of-tree driver, though, so they're probably not helpful. It will be welcome. I have added a few little