Re: [PATCH 2/2] net: ethernet: renesas: sh_eth: don't open code of_device_get_match_data()

2016-03-03 Thread David Miller
From: Wolfram Sang Date: Tue, 1 Mar 2016 17:37:59 +0100 > From: Wolfram Sang > > This change will also make Coverity happy by avoiding a theoretical NULL > pointer dereference; yet another reason is to use the above helper function > to tighten the code and make it more readable. > > Signed-o

Re: [PATCH 2/2] net: ethernet: renesas: sh_eth: don't open code of_device_get_match_data()

2016-03-02 Thread Simon Horman
On Wed, Mar 02, 2016 at 07:46:24AM +0100, Wolfram Sang wrote: > On Wed, Mar 02, 2016 at 10:21:34AM +0900, Simon Horman wrote: > > On Tue, Mar 01, 2016 at 05:37:59PM +0100, Wolfram Sang wrote: > > > From: Wolfram Sang > > > > > > This change will also make Coverity happy by avoiding a theoretical

Re: [PATCH 2/2] net: ethernet: renesas: sh_eth: don't open code of_device_get_match_data()

2016-03-01 Thread Wolfram Sang
On Wed, Mar 02, 2016 at 10:21:34AM +0900, Simon Horman wrote: > On Tue, Mar 01, 2016 at 05:37:59PM +0100, Wolfram Sang wrote: > > From: Wolfram Sang > > > > This change will also make Coverity happy by avoiding a theoretical NULL > > pointer dereference; yet another reason is to use the above hel

Re: [PATCH 2/2] net: ethernet: renesas: sh_eth: don't open code of_device_get_match_data()

2016-03-01 Thread Simon Horman
On Tue, Mar 01, 2016 at 05:37:59PM +0100, Wolfram Sang wrote: > From: Wolfram Sang > > This change will also make Coverity happy by avoiding a theoretical NULL > pointer dereference; yet another reason is to use the above helper function > to tighten the code and make it more readable. > > Signe

[PATCH 2/2] net: ethernet: renesas: sh_eth: don't open code of_device_get_match_data()

2016-03-01 Thread Wolfram Sang
From: Wolfram Sang This change will also make Coverity happy by avoiding a theoretical NULL pointer dereference; yet another reason is to use the above helper function to tighten the code and make it more readable. Signed-off-by: Wolfram Sang --- Tested on a Lager board. drivers/net/ethernet