Re: [PATCH 2/2] rxrpc: fix undefined behavior in rxrpc_mark_call_released

2016-08-31 Thread David Howells
Arnd Bergmann wrote: > Right, sorry about that. Do you want me to resend the fixed version, > or do you apply and fix it yourself? I can fix it up myself. I'll pull it into my tree when I've finished doing the fixing up I'm currently working on. David

Re: [PATCH 2/2] rxrpc: fix undefined behavior in rxrpc_mark_call_released

2016-08-31 Thread David Miller
From: David Howells Date: Wed, 31 Aug 2016 21:25:46 +0100 > Is there a 1/2 somewhere? I don't see it. It was an NFSv4 patch.

Re: [PATCH 2/2] rxrpc: fix undefined behavior in rxrpc_mark_call_released

2016-08-31 Thread Arnd Bergmann
On Wednesday, August 31, 2016 9:26:21 PM CEST David Howells wrote: > Arnd Bergmann wrote: > > > + } else { > > + sched = 0; > > That should be false, not 0, btw. > Right, sorry about that. Do you want me to resend the fixed version, or do you apply and fix it

Re: [PATCH 2/2] rxrpc: fix undefined behavior in rxrpc_mark_call_released

2016-08-31 Thread Arnd Bergmann
On Wednesday, August 31, 2016 9:25:46 PM CEST David Howells wrote: > Is there a 1/2 somewhere? I don't see it. > > David Sorry, mixed up the Cc list. It only went to netdev and lkml and isn't really related. That one was a workaround for a false-positive -Wmaybe-uninitialized warning in NFS,

Re: [PATCH 2/2] rxrpc: fix undefined behavior in rxrpc_mark_call_released

2016-08-31 Thread David Howells
Is there a 1/2 somewhere? I don't see it. David

Re: [PATCH 2/2] rxrpc: fix undefined behavior in rxrpc_mark_call_released

2016-08-31 Thread David Howells
Arnd Bergmann wrote: > + } else { > + sched = 0; That should be false, not 0, btw. David

Re: [PATCH 2/2] rxrpc: fix undefined behavior in rxrpc_mark_call_released

2016-08-31 Thread Arnd Bergmann
On Wednesday, August 31, 2016 6:39:04 PM CEST David Howells wrote: > Arnd Bergmann wrote: > > > gcc -Wmaybe-initialized correctly points out a newly introduced bug > > through which we can end up calling rxrpc_queue_call() for a dead > > connection: > > How do you turn that on

Re: [PATCH 2/2] rxrpc: fix undefined behavior in rxrpc_mark_call_released

2016-08-31 Thread David Howells
Arnd Bergmann wrote: > gcc -Wmaybe-initialized correctly points out a newly introduced bug > through which we can end up calling rxrpc_queue_call() for a dead > connection: How do you turn that on from within the Kbuild system? David

[PATCH 2/2] rxrpc: fix undefined behavior in rxrpc_mark_call_released

2016-08-31 Thread Arnd Bergmann
gcc -Wmaybe-initialized correctly points out a newly introduced bug through which we can end up calling rxrpc_queue_call() for a dead connection: net/rxrpc/call_object.c: In function 'rxrpc_mark_call_released': net/rxrpc/call_object.c:600:5: error: 'sched' may be used uninitialized in this