Re: [PATCH 2/3] can: fix oops caused by wrong rtnl dellink usage

2016-06-28 Thread Oliver Hartkopp
On 06/28/2016 09:36 AM, Holger Schurig wrote: static void can_dellink(struct net_device *dev, struct list_head *head); and static void can_dellink(struct net_device *dev, struct list_head *head) { return; } Wouldn't the canonical form be this: static void can_dellink(struct net_devic

Re: [PATCH 2/3] can: fix oops caused by wrong rtnl dellink usage

2016-06-28 Thread Holger Schurig
> static void can_dellink(struct net_device *dev, struct list_head *head); > > and > > static void can_dellink(struct net_device *dev, struct list_head *head) > { > return; > } Wouldn't the canonical form be this: static void can_dellink(struct net_device *dev, struct list_head *head) { }

Re: [PATCH 2/3] can: fix oops caused by wrong rtnl dellink usage

2016-06-23 Thread Oliver Hartkopp
On 06/23/2016 03:09 PM, Sergei Shtylyov wrote: +static void can_dellink(struct net_device *dev, struct list_head *head) +{ +return; Why? http://marc.info/?l=linux-can&m=146651600421205&w=2 The same reason as for commit 993e6f2fd. I was asking just about the useless *return* sta

Re: [PATCH 2/3] can: fix oops caused by wrong rtnl dellink usage

2016-06-23 Thread Sergei Shtylyov
On 6/23/2016 4:01 PM, Oliver Hartkopp wrote: From: Oliver Hartkopp For 'real' hardware CAN devices the netlink interface is used to set CAN specific communication parameters. Real CAN hardware can not be created nor removed with the ip tool ... This patch adds a private dellink function for t

Re: [PATCH 2/3] can: fix oops caused by wrong rtnl dellink usage

2016-06-23 Thread Oliver Hartkopp
On 06/23/2016 02:55 PM, Sergei Shtylyov wrote: Hello. On 6/23/2016 12:22 PM, Marc Kleine-Budde wrote: From: Oliver Hartkopp For 'real' hardware CAN devices the netlink interface is used to set CAN specific communication parameters. Real CAN hardware can not be created nor removed with the

Re: [PATCH 2/3] can: fix oops caused by wrong rtnl dellink usage

2016-06-23 Thread Sergei Shtylyov
Hello. On 6/23/2016 12:22 PM, Marc Kleine-Budde wrote: From: Oliver Hartkopp For 'real' hardware CAN devices the netlink interface is used to set CAN specific communication parameters. Real CAN hardware can not be created nor removed with the ip tool ... This patch adds a private dellink fun

[PATCH 2/3] can: fix oops caused by wrong rtnl dellink usage

2016-06-23 Thread Marc Kleine-Budde
From: Oliver Hartkopp For 'real' hardware CAN devices the netlink interface is used to set CAN specific communication parameters. Real CAN hardware can not be created nor removed with the ip tool ... This patch adds a private dellink function for the CAN device driver interface that does just no