Re: [PATCH 2/3] virtio: Net header needs gso_hdr_len

2008-01-22 Thread Herbert Xu
On Wed, Jan 16, 2008 at 03:19:03PM +1100, Rusty Russell wrote: It's far easier to deal with GSO if we don't have to parse the packet to figure out the header length. Add the field to the virtio_net_hdr struct (and fix the spaces that somehow crept in there). Why do we need this? When

Re: [PATCH 2/3] virtio: Net header needs gso_hdr_len

2008-01-22 Thread Rusty Russell
On Tuesday 22 January 2008 21:36:30 Herbert Xu wrote: On Wed, Jan 16, 2008 at 03:19:03PM +1100, Rusty Russell wrote: It's far easier to deal with GSO if we don't have to parse the packet to figure out the header length. Add the field to the virtio_net_hdr struct (and fix the spaces

Re: [PATCH 2/3] virtio: Net header needs gso_hdr_len

2008-01-22 Thread Herbert Xu
On Wed, Jan 23, 2008 at 09:06:14AM +1100, Rusty Russell wrote: So this field is fine with me as long as it is named as such to avoid confusion since it really has nothing to do with GSO as you also need it for SG with large MTUs. Hmm, how about just hdr_len rather than gso_hdr_len?

[PATCH 2/3] virtio: Net header needs gso_hdr_len

2008-01-15 Thread Rusty Russell
It's far easier to deal with GSO if we don't have to parse the packet to figure out the header length. Add the field to the virtio_net_hdr struct (and fix the spaces that somehow crept in there). Signed-off-by: Rusty Russell [EMAIL PROTECTED] --- drivers/net/virtio_net.c |4 +++-

Re: [PATCH 2/3] virtio: Net header needs gso_hdr_len

2008-01-15 Thread Herbert Xu
Rusty Russell [EMAIL PROTECTED] wrote: It's far easier to deal with GSO if we don't have to parse the packet to figure out the header length. Add the field to the virtio_net_hdr struct (and fix the spaces that somehow crept in there). Signed-off-by: Rusty Russell [EMAIL PROTECTED] ---

Re: [PATCH 2/3] virtio: Net header needs gso_hdr_len

2008-01-15 Thread Rusty Russell
On Wednesday 16 January 2008 11:06:21 Herbert Xu wrote: Rusty Russell [EMAIL PROTECTED] wrote: It's far easier to deal with GSO if we don't have to parse the packet to figure out the header length. Add the field to the virtio_net_hdr struct (and fix the spaces that somehow crept in there).