Re: [PATCH 2/6] e1000e: remove namespace collisions with e1000

2007-08-14 Thread Kok, Auke
Rick Jones wrote: if you grep around this effort was already started using the 'e1e_' prefix. I like the shorter prefix, but your call ultimately. Either way, make sure to make the driver consistent there too. should it then be consistent with the overall driver name too? certainly calling

Re: [PATCH 2/6] e1000e: remove namespace collisions with e1000

2007-08-14 Thread Rick Jones
if you grep around this effort was already started using the 'e1e_' prefix. I like the shorter prefix, but your call ultimately. Either way, make sure to make the driver consistent there too. should it then be consistent with the overall driver name too? certainly calling things e1e or e1ke

Re: [PATCH 2/6] e1000e: remove namespace collisions with e1000

2007-08-13 Thread Jeff Garzik
Auke Kok wrote: To prevent future collisions we rename all extern's from e1000_ to e1000e_*. The list of changed symbols was taken from e1000.h Compile tested with CONFIG_E1000=y and CONFIG_E1000E=y. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/82571.c | 129 ++