Re: [PATCH 2/7] [PPP] pppoe: Fix data clobbering in __pppoe_xmit and return value

2007-09-16 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Fri, 31 Aug 2007 17:09:04 +0800 > [PPP] pppoe: Fix data clobbering in __pppoe_xmit and return value > > The function __pppoe_xmit modifies the skb data and therefore it needs > to copy and skb data if it's cloned. > > In fact, it currently allocates a n

[PATCH 2/7] [PPP] pppoe: Fix data clobbering in __pppoe_xmit and return value

2007-08-31 Thread Herbert Xu
[PPP] pppoe: Fix data clobbering in __pppoe_xmit and return value The function __pppoe_xmit modifies the skb data and therefore it needs to copy and skb data if it's cloned. In fact, it currently allocates a new skb so that it can return 0 in case of error without freeing the original skb. This