Re: [PATCH 2/9] [I/OAT] Driver for the Intel(R) I/OAT DMA engine

2006-05-30 Thread Adrian Bunk
On Tue, May 23, 2006 at 05:20:13PM -0700, Chris Leech wrote: Adds a new ioatdma driver Signed-off-by: Chris Leech [EMAIL PROTECTED] --- drivers/dma/Kconfig |9 drivers/dma/Makefile|1 drivers/dma/ioatdma.c | 839

Re: [PATCH 2/9] [I/OAT] Driver for the Intel(R) I/OAT DMA engine

2006-05-25 Thread Olof Johansson
Hi, Minor nitpick below: On Tue, May 23, 2006 at 05:20:13PM -0700, Chris Leech wrote: +static int enumerate_dma_channels(struct ioat_device *device) [...] + enumerate_dma_channels(device); Return value is never used, might as well change the function declaration to void. -Olof - To

[PATCH 2/9] [I/OAT] Driver for the Intel(R) I/OAT DMA engine

2006-05-23 Thread Chris Leech
Adds a new ioatdma driver Signed-off-by: Chris Leech [EMAIL PROTECTED] --- drivers/dma/Kconfig |9 drivers/dma/Makefile|1 drivers/dma/ioatdma.c | 839 +++ drivers/dma/ioatdma.h | 126 ++

Re: [PATCH 2/9] [I/OAT] Driver for the Intel(R) I/OAT DMA engine

2006-05-23 Thread Andrew Morton
Chris Leech [EMAIL PROTECTED] wrote: +static void ioat_dma_memcpy_cleanup(struct ioat_dma_chan *chan) +{ +unsigned long phys_complete; +struct ioat_desc_sw *desc, *_desc; +dma_cookie_t cookie = 0; + +prefetch(chan-completion_virt); + +if

[PATCH 2/9] I/OAT network recv copy offload

2006-05-08 Thread Chris Leech
[I/OAT] Driver for the Intel(R) I/OAT DMA engine From: Chris Leech [EMAIL PROTECTED] Adds a new ioatdma driver Signed-off-by: Chris Leech [EMAIL PROTECTED] --- drivers/dma/Kconfig |9 drivers/dma/Makefile|1 drivers/dma/ioatdma.c | 839

Re: [PATCH 2/9] I/OAT

2006-03-31 Thread Chris Leech
Could you please describe how struct ioat_dma_chan channels are freed? Sorry, I got distracted by other issues and never ended up following up on this. You're right, and it's just sloppiness on my part for missing it, those structs are being leaked on module unload. I'll fix it. Thanks.

[PATCH 2/9] I/OAT

2006-03-29 Thread Chris Leech
[I/OAT] Driver for the Intel(R) I/OAT DMA engine From: Chris Leech [EMAIL PROTECTED] Adds a new ioatdma driver Signed-off-by: Chris Leech [EMAIL PROTECTED] --- drivers/dma/Kconfig |9 drivers/dma/Makefile|1 drivers/dma/ioatdma.c | 805

Re: [PATCH 2/9] I/OAT

2006-03-29 Thread Evgeniy Polyakov
On Wed, Mar 29, 2006 at 02:54:04PM -0800, Chris Leech ([EMAIL PROTECTED]) wrote: [I/OAT] Driver for the Intel(R) I/OAT DMA engine From: Chris Leech [EMAIL PROTECTED] Adds a new ioatdma driver Signed-off-by: Chris Leech [EMAIL PROTECTED] Let's do it again. Could you please describe how