Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

David Miller wrote: > As you can with the function tracer and tracepoints. I've had experience with tracepoints before (i2c and smbus). It wasn't particularly fun. There's got to be some easier way to write them. Hmmm... Of the _enter() and _leave() macros in my tree at

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

From: David Howells Date: Thu, 07 Apr 2016 21:47:19 +0100 > David Miller wrote: > >> > Excellent only if I can get at it to find out why the something went wrong. >> > If it's lost because the machine panics, then it is worthless. >> >> If you're ok

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

David Miller wrote: > > Excellent only if I can get at it to find out why the something went wrong. > > If it's lost because the machine panics, then it is worthless. > > If you're ok with these kenter things spewing into the logs with the > current facility, you can run

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

Joe Perches wrote: > > Let's see...  If the machine panics whilst I'm developing stuff (quite > > likely if something goes wrong in BH context), how do I get at the > > function tracing log to find out why it panicked if the log is then > > lost?  With the serial console, at

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

From: David Howells Date: Thu, 07 Apr 2016 20:45:08 +0100 > David Miller wrote: > >> Yeah this custom stuff is really inappropriate given the excellent >> infrastructure we have these days... > > Excellent only if I can get at it to find out why the

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

On Thu, 2016-04-07 at 20:43 +0100, David Howells wrote: > Joe Perches wrote: > > > Joe Perches wrote: > > > > It might be better to remove kenter and _enter > > > > altogether and use function tracing instead. > > > Possibly - but not at this time. > > Swell.

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

David Miller wrote: > Yeah this custom stuff is really inappropriate given the excellent > infrastructure we have these days... Excellent only if I can get at it to find out why the something went wrong. If it's lost because the machine panics, then it is worthless. David

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

Joe Perches wrote: > > Joe Perches wrote: > > > It might be better to remove kenter and _enter > > > altogether and use function tracing instead. > > Possibly - but not at this time. > > Swell. I didn't say I wouldn't do it - it's just that I'm trying to

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

From: Joe Perches Date: Thu, 07 Apr 2016 09:31:17 -0700 > On Thu, 2016-04-07 at 17:23 +0100, David Howells wrote: >> Disable a debugging statement that has been left enabled >> >> Signed-off-by: David Howells >> --- >> >>  net/rxrpc/ar-ack.c |2 +- >>

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

On Thu, 2016-04-07 at 18:05 +0100, David Howells wrote: > Joe Perches wrote: > > It might be better to remove kenter and _enter > > altogether and use function tracing instead. > Possibly - but not at this time. Swell. > Besides, isn't the function tracing log lost > if the

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

Joe Perches wrote: > It might be better to remove kenter and _enter > altogether and use function tracing instead. Possibly - but not at this time. Besides, isn't the function tracing log lost if the machine crashes? David

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

On Thu, 2016-04-07 at 17:23 +0100, David Howells wrote: > Disable a debugging statement that has been left enabled > > Signed-off-by: David Howells > --- > >  net/rxrpc/ar-ack.c |2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/rxrpc/ar-ack.c

[PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

Disable a debugging statement that has been left enabled Signed-off-by: David Howells --- net/rxrpc/ar-ack.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rxrpc/ar-ack.c b/net/rxrpc/ar-ack.c index 16d967075eaf..01a017a05f14 100644 ---