Re: [PATCH 3/14] nes: connection manager routines

2007-08-09 Thread Steve Wise
Glenn Grundstrom wrote: This code is far from a TCP stack. It's main purpose is to exchange RDMA MPA request/response messages that are required by the iWarp specs and therefore needed by our hardware. All RNIC hardware vendors need this MPA message exchange, including those already accepted

Re: [PATCH 3/14] nes: connection manager routines

2007-08-09 Thread Roland Dreier
> > +atomic_t cm_connects; > > +atomic_t cm_accepts; > > +atomic_t cm_disconnects; > > +atomic_t cm_closes; > > +atomic_t cm_connecteds; > > +atomic_t cm_connect_reqs; > > +atomic_t cm_rejects; > > do you really want to take the hit of a LOCK prefix each time you > increment a stat??? I

RE: [PATCH 3/14] nes: connection manager routines

2007-08-08 Thread Glenn Grundstrom
3/14] nes: connection manager routines [EMAIL PROTECTED] writes: > NetEffect connection manager routines. This seems more like a new TCP stack. I don't think such code is appropiate, since Linux already has one. -Andi - To unsubscribe from this list: send the line "unsubscribe netd

Re: [PATCH 3/14] nes: connection manager routines

2007-08-08 Thread Andi Kleen
[EMAIL PROTECTED] writes: > NetEffect connection manager routines. This seems more like a new TCP stack. I don't think such code is appropiate, since Linux already has one. -Andi - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] Mor

Re: [PATCH 3/14] nes: connection manager routines

2007-08-07 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: +atomic_t cm_connects; +atomic_t cm_accepts; +atomic_t cm_disconnects; +atomic_t cm_closes; +atomic_t cm_connecteds; +atomic_t cm_connect_reqs; +atomic_t cm_rejects; do you really want to take the hit of a LOCK prefix each time you increment a stat??? +static struc