Re: [PATCH 3/3] 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-09-29 Thread Thomas F Herbert
On 9/29/15 6:56 PM, Pravin Shelar wrote: On Fri, Sep 25, 2015 at 3:35 PM, Thomas F Herbert wrote: Pravin, Another comment and question. Please seen inline below. Thanks, --Tom On 9/24/15 7:42 PM, Pravin Shelar wrote: On Thu, Sep 24, 2015 at 10:58 AM, Thomas F Herbert wrote: Add support f

Re: [PATCH 3/3] 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-09-29 Thread Pravin Shelar
On Fri, Sep 25, 2015 at 3:35 PM, Thomas F Herbert wrote: > Pravin, > > Another comment and question. Please seen inline below. > > Thanks, > > --Tom > > On 9/24/15 7:42 PM, Pravin Shelar wrote: >> >> On Thu, Sep 24, 2015 at 10:58 AM, Thomas F Herbert >> wrote: >>> >>> Add support for 802.1ad incl

Re: [PATCH 3/3] 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-09-25 Thread Thomas F Herbert
Pravin, Another comment and question. Please seen inline below. Thanks, --Tom On 9/24/15 7:42 PM, Pravin Shelar wrote: On Thu, Sep 24, 2015 at 10:58 AM, Thomas F Herbert wrote: Add support for 802.1ad including the ability to push and pop double tagged vlans. Add support for 802.1ad to netl

Re: [PATCH 3/3] 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-09-25 Thread Thomas F Herbert
Pravin, Thanks for the review, Comments in line below. --TFH On 9/24/15 7:42 PM, Pravin Shelar wrote: On Thu, Sep 24, 2015 at 10:58 AM, Thomas F Herbert wrote: Add support for 802.1ad including the ability to push and pop double tagged vlans. Add support for 802.1ad to netlink parsing and f

Re: [PATCH 3/3] 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-09-24 Thread Pravin Shelar
On Thu, Sep 24, 2015 at 10:58 AM, Thomas F Herbert wrote: > Add support for 802.1ad including the ability to push and pop double > tagged vlans. Add support for 802.1ad to netlink parsing and flow > conversion. Uses double nested encap attributes to represent double > tagged vlan. Inner TPID encod

[PATCH 3/3] 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-09-24 Thread Thomas F Herbert
Add support for 802.1ad including the ability to push and pop double tagged vlans. Add support for 802.1ad to netlink parsing and flow conversion. Uses double nested encap attributes to represent double tagged vlan. Inner TPID encoded along with ctci in nested attributes. Signed-off-by: Thomas F H